Merge pull request #27 from PDOK/PDOK-17899-immutable-url

Changed base URL check to shared function

Author: Daimanta

api/v3/wfs_types.go

@@ -244,3 +244,7 @@ func (wfs *WFS) GeoPackages() []*Gpkg {
 
 	return gpkgs
 }
+
+func (wfs *WFS) GetBaseUrl() string {
+	return wfs.Spec.Service.URL
+}

api/v3/wfs_validation.go

@@ -35,10 +35,7 @@ func (wfs *WFS) ValidateUpdate(wfsOld *WFS) ([]string, error) {
 		reasons = append(reasons, fmt.Sprintf("%v", err))
 	}
 
-	// Check service.baseURL did not change
-	if wfs.Spec.Service.URL != wfsOld.Spec.Service.URL {
-		reasons = append(reasons, "service.baseURL is immutable")
-	}
+	sharedValidation.CheckBaseUrlImmutability(wfsOld, wfs, &reasons)
 
 	if (wfs.Spec.Service.Inspire == nil && wfsOld.Spec.Service.Inspire != nil) || (wfs.Spec.Service.Inspire != nil && wfsOld.Spec.Service.Inspire == nil) {
 		reasons = append(reasons, "services cannot change from inspire to not inspire or the other way around")

api/v3/wms_types.go

@@ -561,3 +561,7 @@ func (wms *WMS) GeoPackages() []*Gpkg {
 
 	return gpkgs
 }
+
+func (wms *WMS) GetBaseUrl() string {
+	return wms.Spec.Service.URL
+}

api/v3/wms_validation.go

@@ -36,10 +36,7 @@ func (wms *WMS) ValidateUpdate(wmsOld *WMS) ([]string, error) {
 		reasons = append(reasons, fmt.Sprintf("%v", err))
 	}
 
-	// Check service.baseURL did not change
-	if wms.Spec.Service.URL != wmsOld.Spec.Service.URL {
-		reasons = append(reasons, "service.baseURL is immutable")
-	}
+	sharedValidation.CheckBaseUrlImmutability(wmsOld, wms, &reasons)
 
 	if (wms.Spec.Service.Inspire == nil && wmsOld.Spec.Service.Inspire != nil) || (wms.Spec.Service.Inspire != nil && wmsOld.Spec.Service.Inspire == nil) {
 		reasons = append(reasons, "services cannot change from inspire to not inspire or the other way around")

go.mod

@@ -13,7 +13,7 @@ require (
 	github.com/pdok/featureinfo-generator v1.4.0-beta1
 	github.com/pdok/ogc-capabilities-generator v1.0.0-beta7
 	github.com/pdok/ogc-specifications v1.0.0-beta7
-	github.com/pdok/smooth-operator v0.0.16
+	github.com/pdok/smooth-operator v0.0.18-0.20250502130008-44dd7efe5125
 	github.com/stretchr/testify v1.10.0
 	github.com/traefik/traefik/v3 v3.3.4
 	k8s.io/api v0.32.3

go.sum

@@ -155,6 +155,8 @@ github.com/pdok/ogc-specifications v1.0.0-beta7 h1:AFSO8iCYbD1MrjOS2q+PGp2PmSqAH
 github.com/pdok/ogc-specifications v1.0.0-beta7/go.mod h1:YDngwkwrWOfc5MYnEYseiv97K1Y9bZXlVzwi/8EaIl8=
 github.com/pdok/smooth-operator v0.0.16 h1:1vurI2TPDHmTaTu0YeG1B9mIIa5MT6GPWhixiZ/styg=
 github.com/pdok/smooth-operator v0.0.16/go.mod h1:ohDqrUnmS7wK8TrNHJnFS/mDgf26Yhb8mtRBX3ixdr4=
+github.com/pdok/smooth-operator v0.0.18-0.20250502130008-44dd7efe5125 h1:0ZIPfe6USM5Jm0MC8tngDxPIFvBSTOrNY53S7pA9Lh4=
+github.com/pdok/smooth-operator v0.0.18-0.20250502130008-44dd7efe5125/go.mod h1:ohDqrUnmS7wK8TrNHJnFS/mDgf26Yhb8mtRBX3ixdr4=
 github.com/pkg/errors v0.9.1 h1:FEBLx1zS214owpjy7qsBeixbURkuhQAwrK5UwLGTwt4=
 github.com/pkg/errors v0.9.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
 github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=