Skip to content

Commit fdf7e06

Browse files
Merge pull request #106 from PDOK/jd/optional-options
Made all options optional
2 parents 7407f7d + f39280f commit fdf7e06

File tree

4 files changed

+7
-12
lines changed

4 files changed

+7
-12
lines changed

api/v3/shared_types.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,15 +70,18 @@ type Mapfile struct {
7070
type BaseOptions struct {
7171
// IncludeIngress dictates whether to deploy an Ingress or ensure none exists.
7272
// +kubebuilder:default:=true
73+
// +kubebuilder:validation:Optional
7374
IncludeIngress bool `json:"includeIngress"`
7475

7576
// AutomaticCasing enables automatic conversion from snake_case to camelCase.
7677
// +kubebuilder:default:=true
78+
// +kubebuilder:validation:Optional
7779
AutomaticCasing bool `json:"automaticCasing"`
7880

7981
// Whether to prefetch data from blob storage, and store it on the local filesystem.
8082
// If `false`, the data will be served directly out of blob storage
8183
// +kubebuilder:default:=true
84+
// +kubebuilder:validation:Optional
8285
PrefetchData bool `json:"prefetchData"`
8386
}
8487

api/v3/wms_types.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -312,18 +312,22 @@ type WMSOptions struct {
312312

313313
// ValidateRequests enables request validation against the service schema.
314314
// +kubebuilder:default:=true
315+
// +kubebuilder:validation:Optional
315316
ValidateRequests bool `json:"validateRequests"`
316317

317318
// RewriteGroupToDataLayers merges group layers into individual data layers.
318319
// +kubebuilder:default:=false
320+
// +kubebuilder:validation:Optional
319321
RewriteGroupToDataLayers bool `json:"rewriteGroupToDataLayers"`
320322

321323
// DisableWebserviceProxy disables the built-in proxy for external web services.
322324
// +kubebuilder:default:=false
325+
// +kubebuilder:validation:Optional
323326
DisableWebserviceProxy bool `json:"disableWebserviceProxy"`
324327

325328
// ValidateChildStyleNameEqual ensures child style names match the parent style.
326329
// +kubebuilder:default=false
330+
// +kubebuilder:validation:Optional
327331
ValidateChildStyleNameEqual bool `json:"validateChildStyleNameEqual"`
328332
}
329333

config/crd/bases/pdok.nl_wfs.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -690,10 +690,6 @@ spec:
690690
Whether to prefetch data from blob storage, and store it on the local filesystem.
691691
If `false`, the data will be served directly out of blob storage
692692
type: boolean
693-
required:
694-
- automaticCasing
695-
- includeIngress
696-
- prefetchData
697693
type: object
698694
podSpecPatch:
699695
description: Strategic merge patch for the pod in the deployment. E.g. to patch the resources or add extra env vars.

config/crd/bases/pdok.nl_wms.yaml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -733,14 +733,6 @@ spec:
733733
default: true
734734
description: ValidateRequests enables request validation against the service schema.
735735
type: boolean
736-
required:
737-
- automaticCasing
738-
- disableWebserviceProxy
739-
- includeIngress
740-
- prefetchData
741-
- rewriteGroupToDataLayers
742-
- validateChildStyleNameEqual
743-
- validateRequests
744736
type: object
745737
podSpecPatch:
746738
description: Strategic merge patch for the pod in the deployment. E.g. to patch the resources or add extra env vars.

0 commit comments

Comments
 (0)