Make llvm not default for Rust (#192)

* make the llvm feature not default for Rust

Author: ciaranra

.github/workflows/rust-test.yml

@@ -74,7 +74,13 @@ jobs:
         run: rustup component add clippy
 
       - name: Run clippy
-        run: cargo clippy --workspace --all-targets -- -D warnings
+        run: |
+          echo "Running clippy with all features (including LLVM)..."
+          cargo clippy --workspace --exclude pecos --exclude pecos-quest --all-targets --all-features -- -D warnings
+          echo "Running clippy on pecos with all non-GPU features..."
+          cargo clippy -p pecos --all-targets --features "llvm,selene,qasm,phir,all-simulators" -- -D warnings
+          echo "Running clippy on pecos-quest with CPU features only..."
+          cargo clippy -p pecos-quest --all-targets --features "cpu" -- -D warnings
 
   rust-lint-no-llvm:
     runs-on: ubuntu-latest
@@ -245,11 +251,16 @@ jobs:
 
           echo "RUSTFLAGS: $RUSTFLAGS"
 
-          cargo test --no-run
+          cargo test --no-run --workspace --exclude pecos-quest --exclude pecos-decoders --features llvm
+          cargo test --no-run -p pecos-quest --features cpu
+          cargo test --no-run -p pecos-decoders --all-features
 
       - name: Compile tests (Linux/Windows)
         if: matrix.os != 'macos-latest'
-        run: cargo test --no-run
+        run: |
+          cargo test --no-run --workspace --exclude pecos-quest --exclude pecos-decoders --features llvm
+          cargo test --no-run -p pecos-quest --features cpu
+          cargo test --no-run -p pecos-decoders --all-features
 
       - name: Run tests (macOS)
         if: matrix.os == 'macos-latest'
@@ -264,23 +275,32 @@ jobs:
           unset PKG_CONFIG_PATH
           export LIBRARY_PATH=/usr/lib
 
-          cargo test --workspace
+          cargo test --workspace --exclude pecos-quest --exclude pecos-decoders --features llvm
+          cargo test -p pecos-quest --features cpu
+          cargo test -p pecos-decoders --all-features
 
       - name: Run tests (Linux)
         if: matrix.os == 'ubuntu-latest'
-        run: cargo test --workspace
+        run: |
+          cargo test --workspace --exclude pecos-quest --exclude pecos-decoders --features llvm
+          cargo test -p pecos-quest --features cpu
+          cargo test -p pecos-decoders --all-features
 
       - name: Run tests (Windows)
         if: matrix.os == 'windows-latest'
         run: |
           # Run all non-doctest tests
-          cargo test --workspace --exclude pecos-rslib --lib --bins --tests --examples
+          cargo test --workspace --exclude pecos-quest --exclude pecos-decoders --exclude pecos-rslib --features llvm --lib --bins --tests --examples
+          cargo test -p pecos-quest --features cpu --lib --bins --tests --examples
+          cargo test -p pecos-decoders --all-features --lib --bins --tests --examples
 
           # For Windows, we need to run doctests for the pecos crate specially
           # to ensure they run from the crate directory
           cd crates/pecos
-          cargo test --doc
+          cargo test --doc --features llvm
           cd ../..
 
           # Run doctests for other crates normally
-          cargo test --workspace --exclude pecos-rslib --exclude pecos --doc
+          cargo test --workspace --exclude pecos-quest --exclude pecos-decoders --exclude pecos-rslib --exclude pecos --features llvm --doc
+          cargo test -p pecos-quest --doc
+          cargo test -p pecos-decoders --all-features --doc

Makefile

@@ -237,14 +237,32 @@ lint-fix:  ## Fix all auto-fixable linting issues (Rust, Python, Julia)
 # -------
 
 .PHONY: rstest
-rstest:  ## Run Rust tests
-	@$(ADD_LLVM_TO_PATH) cargo test --workspace --release
+rstest:  ## Run Rust tests (with GPU features only if CUDA available)
+	@if [ "$(CUDA_AVAILABLE)" = "no" ]; then \
+		echo "CUDA not detected - testing all features except GPU"; \
+		$(ADD_LLVM_TO_PATH) cargo test --workspace --release --exclude pecos-quest --exclude pecos-decoders --features llvm; \
+		$(ADD_LLVM_TO_PATH) cargo test -p pecos-quest --release --features cpu; \
+		$(ADD_LLVM_TO_PATH) cargo test -p pecos-decoders --release --all-features; \
+	else \
+		echo "CUDA detected - testing with all features including GPU"; \
+		$(ADD_LLVM_TO_PATH) cargo test --workspace --release --exclude pecos-quest --exclude pecos-decoders --features llvm; \
+		$(ADD_LLVM_TO_PATH) cargo test -p pecos-quest --release --all-features; \
+		$(ADD_LLVM_TO_PATH) cargo test -p pecos-decoders --release --all-features; \
+	fi
 
 .PHONY: rstest-all
-rstest-all:  ## Run Rust tests with all features except GPU
-	@$(ADD_LLVM_TO_PATH) cargo test --workspace --exclude pecos-quest --exclude pecos-decoders
-	@$(ADD_LLVM_TO_PATH) cargo test -p pecos-quest
-	@$(ADD_LLVM_TO_PATH) cargo test -p pecos-decoders --all-features
+rstest-all:  ## Run Rust tests with all features (including GPU if CUDA available)
+	@if [ "$(CUDA_AVAILABLE)" = "no" ]; then \
+		echo "CUDA not detected - testing all features except GPU"; \
+		$(ADD_LLVM_TO_PATH) cargo test --workspace --exclude pecos-quest --exclude pecos-decoders --features llvm; \
+		$(ADD_LLVM_TO_PATH) cargo test -p pecos-quest --features cpu; \
+		$(ADD_LLVM_TO_PATH) cargo test -p pecos-decoders --all-features; \
+	else \
+		echo "CUDA detected - testing with all features including GPU"; \
+		$(ADD_LLVM_TO_PATH) cargo test --workspace --exclude pecos-quest --exclude pecos-decoders --features llvm; \
+		$(ADD_LLVM_TO_PATH) cargo test -p pecos-quest --all-features; \
+		$(ADD_LLVM_TO_PATH) cargo test -p pecos-decoders --all-features; \
+	fi
 
 # Decoder-specific commands
 # -------------------------

crates/pecos-cli/Cargo.toml

@@ -23,7 +23,7 @@ env_logger.workspace = true
 log.workspace = true
 
 [features]
-default = ["qasm", "llvm", "phir", "selene"]
+default = ["qasm", "phir", "selene"]
 qasm = ["pecos/qasm"]
 llvm = ["pecos/llvm"]
 phir = ["pecos/phir"]

crates/pecos-hugr-qis/Cargo.toml

@@ -27,7 +27,7 @@ tket.workspace = true
 tket-qsystem.workspace = true
 
 [features]
-default = ["llvm"]
+default = []
 llvm = ["tket-qsystem/llvm"]
 
 [lints]

crates/pecos-qis-core/Cargo.toml

@@ -30,7 +30,7 @@ features = ["llvm14-0"]
 optional = true
 
 [features]
-default = ["llvm"]
+default = []
 llvm = ["dep:inkwell"]
 
 [build-dependencies]

crates/pecos/Cargo.toml

@@ -38,7 +38,7 @@ pecos-quest = { workspace = true, optional = true }
 pecos-qulacs = { workspace = true, optional = true }
 
 [features]
-default = ["selene", "llvm", "qasm", "phir", "all-simulators"]
+default = ["selene", "qasm", "phir", "all-simulators"]
 qasm = []
 llvm = ["pecos-qis-core/llvm", "pecos-hugr-qis", "pecos-hugr-qis?/llvm"]
 phir = []

julia/pecos-julia-ffi/Cargo.toml

@@ -17,7 +17,8 @@ crate-type = ["cdylib"]
 
 [dependencies]
 # PECOS - the meta crate that includes everything via its prelude
-pecos = { workspace = true }
+# Enable llvm feature explicitly for full Julia functionality
+pecos = { workspace = true, features = ["llvm"] }
 
 [lints]
 workspace = true

python/pecos-rslib/rust/Cargo.toml

@@ -21,7 +21,8 @@ test = false
 
 [dependencies]
 # Use the pecos metacrate which includes all simulators and runtimes by default
-pecos = { workspace = true }
+# Enable llvm feature explicitly for full Python functionality
+pecos = { workspace = true, features = ["llvm"] }
 
 pyo3 = { workspace=true, features = ["extension-module", "abi3-py310", "generate-import-lib"] }
 parking_lot.workspace = true

python/quantum-pecos/src/pecos/engines/hybrid_engine.py

@@ -154,6 +154,9 @@ def initialize_sim_components(
         self.machine.init(num_qubits)
         self.error_model.init(num_qubits, self.machine)
         self.op_processor.init()
+        # Pass seed to quantum simulator if one was set
+        if self.seed is not None:
+            self.qsim.qsim_params["seed"] = self.seed
         self.qsim.init(num_qubits)
 
     def shot_reinit_components(self) -> None:

python/quantum-pecos/src/pecos/simulators/quantum_simulator.py

@@ -114,7 +114,20 @@ def init(self, num_qubits: int) -> None:
         if self.backend is None:
             self.state = SparseSim
 
-        self.state = self.state(num_qubits=num_qubits, **self.qsim_params)
+        # Try to initialize with all params including seed
+        # If the simulator doesn't support seed, retry without it
+        try:
+            self.state = self.state(num_qubits=num_qubits, **self.qsim_params)
+        except TypeError as e:
+            if "seed" in str(e) and "unexpected keyword argument" in str(e):
+                # Simulator doesn't support seed parameter, retry without it
+                params_without_seed = {
+                    k: v for k, v in self.qsim_params.items() if k != "seed"
+                }
+                self.state = self.state(num_qubits=num_qubits, **params_without_seed)
+            else:
+                # Different TypeError, re-raise it
+                raise
 
     def shot_reinit(self) -> None:
         """Run all code needed at the beginning of each shot, e.g., resetting state."""