Skip to content

Commit 1cac9c2

Browse files
committed
observable
1 parent 91f6923 commit 1cac9c2

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

petab/v2/core.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
import tempfile
99
import traceback
1010
from abc import abstractmethod
11-
from collections import OrderedDict
1211
from collections.abc import Sequence
1312
from enum import Enum
1413
from itertools import chain
@@ -2280,14 +2279,14 @@ def get_measurements_for_experiment(
22802279
]
22812280

22822281
def get_output_parameters(
2283-
self, observables: bool = True, noise: bool = True
2282+
self, observable: bool = True, noise: bool = True
22842283
) -> list[str]:
22852284
"""Get output parameters.
22862285
22872286
Returns IDs of symbols used in observable and noise formulas that are
22882287
not observables and that are not defined in the model.
22892288
2290-
:param observables:
2289+
:param observable:
22912290
Include parameters from observableFormulas
22922291
:param noise:
22932292
Include parameters from noiseFormulas
@@ -2297,7 +2296,7 @@ def get_output_parameters(
22972296
# collect free symbols from observable and noise formulas,
22982297
# skipping observable IDs
22992298
candidates = set()
2300-
if observables:
2299+
if observable:
23012300
candidates |= {
23022301
str_sym
23032302
for o in self.observables

tests/v1/test_petab.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -867,7 +867,7 @@ def test_get_required_parameters_for_parameter_table(petab_problem):
867867
noise_placeholders = petab.observables.get_output_parameters(
868868
petab_problem.observable_df,
869869
petab_problem.model,
870-
observables=False,
870+
observable=False,
871871
noise=True,
872872
)
873873
# The observable parameter (scaling) appears in the noise formula,

tests/v2/test_core.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -804,12 +804,12 @@ def test_get_output_parameters():
804804
)
805805
assert (
806806
petab_problem.get_output_parameters()
807-
== petab_problem.get_output_parameters(observables=True, noise=True)
807+
== petab_problem.get_output_parameters(observable=True, noise=True)
808808
== ["p1", "p3", "p4", "p5"]
809809
)
810810
assert petab_problem.get_output_parameters(
811-
observables=True, noise=False
811+
observable=True, noise=False
812812
) == ["p1", "p3", "p4"]
813813
assert petab_problem.get_output_parameters(
814-
observables=False, noise=True
814+
observable=False, noise=True
815815
) == ["p1", "p3", "p5"]

0 commit comments

Comments
 (0)