..

Author: dweindl

petab/v1/measurements.py

@@ -307,7 +307,6 @@ def assert_overrides_match_parameter_count(
                 row.get(OBSERVABLE_PARAMETERS, None)
             )
         )
-        # No overrides are also allowed
         if actual != expected:
             formula = observable_df.loc[row[OBSERVABLE_ID], OBSERVABLE_FORMULA]
             raise AssertionError(
@@ -324,7 +323,6 @@ def assert_overrides_match_parameter_count(
         try:
             expected = noise_parameters_count[row[OBSERVABLE_ID]]
 
-            # No overrides are also allowed
             if len(replacements) != expected:
                 raise AssertionError(
                     f"Mismatch of noise parameter overrides in:\n{row}\n"

tests/v2/test_core.py

@@ -848,7 +848,12 @@ def test_problem_has_timepoint_specific_overrides():
         measurement=0.1,
         observable_parameters=["obsParOverride"],
     )
-    problem.add_measurement(obs_id="obs1", time=1.0, measurement=0.2)
+    problem.add_measurement(
+        obs_id="obs1",
+        time=1.0,
+        measurement=0.2,
+        observable_parameters=["obsParOverride2"],
+    )
     assert problem.has_timepoint_specific_overrides() is True
 
     # both measurements different anyways