Skip to content

Commit 59c4216

Browse files
authored
fix ParameterScale sampler fixes #491 (#492)
* fix ParameterScaleUniform * trafo in get_priors_from_df * clarify documentation
1 parent d948970 commit 59c4216

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

doc/documentation_data_format.rst

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -537,6 +537,9 @@ Detailed field description
537537

538538
Prior parameters used for sampling of initial points for optimization,
539539
separated by a semicolon. Defaults to ``lowerBound;upperBound``.
540+
The parameters are expected to be in linear scale except for the
541+
``parameterScale`` priors, where the prior parameters are expected to be
542+
in parameter scale.
540543

541544
So far, only numeric values will be supported, no parameter names.
542545
Parameters for the different prior types are:

petab/parameters.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,8 @@ def get_priors_from_df(parameter_df: pd.DataFrame,
343343
# if no prior is specified, we assume a non-informative (uniform) one
344344
if prior_type == 'nan':
345345
prior_type = PARAMETER_SCALE_UNIFORM
346-
prior_pars = (row[LOWER_BOUND], row[UPPER_BOUND])
346+
prior_pars = (scale(row[LOWER_BOUND], par_scale),
347+
scale(row[UPPER_BOUND], par_scale))
347348

348349
prior_list.append((prior_type, prior_pars, par_scale, par_bounds))
349350

0 commit comments

Comments
 (0)