,.

Author: dweindl

petab/v2/converters.py

@@ -103,17 +103,34 @@ def _preprocess(self):
             if self._max_event_priority is not None
             else None
         )
-        # Check for undefined event priorities and warn
+
         for event in model.getListOfEvents():
+            # Check for undefined event priorities and warn
             if (prio := event.getPriority()) and prio.getMath() is None:
                 warnings.warn(
                     f"Event `{event.getId()}` has no priority set. "
                     "Make sure that this event cannot trigger at the time of "
-                    "PEtab condition change, otherwise the behavior is "
+                    "a PEtab condition change, otherwise the behavior is "
                     "undefined.",
                     stacklevel=1,
                 )
 
+            # Check for useValuesFromTrigger time
+            if event.getUseValuesFromTriggerTime():
+                # Non-PEtab-condition-change events must be executed *after*
+                #  PEtab condition changes have been applied, based on the
+                #  updated model state. This would be violated by
+                #  useValuesFromTriggerTime=true.
+                warnings.warn(
+                    f"Event `{event.getId()}` has "
+                    "`useValuesFromTriggerTime=true'. "
+                    "Make sure that this event cannot trigger at the time of "
+                    "a PEtab condition change, or consider changing "
+                    "`useValuesFromTriggerTime' to `false'. Otherwise "
+                    "simulation results may be incorrect.",
+                    stacklevel=1,
+                )
+
     def convert(self) -> Problem:
         """Convert the PEtab experiments to SBML events.