Merge pull request #772 from PHOENIXCONTACT/refactor/deprecated

Removed deprecated code

Author: dbeuchler

docs/migrations/v8_to_v10.md

@@ -41,3 +41,19 @@ With MORYX 10, several changes have been made to the data model to improve perfo
 ### Removal of ProductFileEntity
 
 The `ProductFileEntity` has been removed from the data model as it was not utilized effectively. This change helps streamline the data structure and reduce unnecessary complexity.
+
+## Rarely used features removed
+
+These feature were infrequently used and has been removed to simplify the codebase.
+
+- ExceptionPrinter: Used to print exceptions to different outputs. Use Exception.ToString() instead.
+- CrashHandler: Used to handle application crashes. This feature was used were the runtime was a console application.
+- Caller: Used to get information about the calling method. Use System.Diagnostics.StackTrace instead.
+- Moryx.Endpoints: This namespace contained all base classes for the time when an endpoint was hosted inside a module. Since we use controllers it is deprecated.
+- Moryx.Identity: This namespace contained base classes and services for the old WPF client to provide the authorization context. Since MORYX support web uis, this is deprecated
+- PortConfig: Used for old wcf services. Deprecated since ASP.NET Core.
+- ProxyConfig.Port: Use the full address instead. It contains also http/https, domain and port
+
+## Moved classes and namespaces
+
+- Moryx.Tools.FunctionResult: Moved to Moryx.Tools

src/Moryx.Analytics.Server/ModuleController/ModuleController.cs

@@ -3,7 +3,6 @@
 
 using System.ComponentModel;
 using Microsoft.Extensions.Logging;
-using Moryx.Communication.Endpoints;
 using Moryx.Configuration;
 using Moryx.Container;
 using Moryx.Runtime.Modules;
@@ -16,8 +15,6 @@ namespace Moryx.Analytics.Server.ModuleController
     [Description("Modul to analyze data and visualize in Dashboards")]
     public class ModuleController : ServerModuleBase<ModuleConfig>
     {
-        private IEndpointHost _host;
-
         /// <summary>
         /// The module's name.
         /// </summary>
@@ -51,8 +48,6 @@ protected override void OnStart()
         /// </summary>
         protected override void OnStop()
         {
-            _host.Stop();
-            _host = null;
         }
 
         #endregion

src/Moryx.Asp.Extensions/Moryx.Asp.Extensions.csproj

@@ -1,14 +1,15 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
-	<PropertyGroup>
-		<TargetFramework>net8.0</TargetFramework>
-		<Description>Extensions for the Integration of MORYX in ASP.NET Core</Description>
-		<PackageTags>MORYX;ASP</PackageTags>
-		<IsPackable>true</IsPackable>
-	</PropertyGroup>
+  <PropertyGroup>
+    <TargetFramework>net8.0</TargetFramework>
+    <GenerateDocumentationFile>true</GenerateDocumentationFile>
+    <Description>Extensions for the Integration of MORYX in ASP.NET Core</Description>
+    <PackageTags>MORYX;ASP</PackageTags>
+    <IsPackable>true</IsPackable>
+  </PropertyGroup>
 
-	<ItemGroup>
-		<FrameworkReference Include="Microsoft.AspNetCore.App" />
-	</ItemGroup>
+  <ItemGroup>
+    <FrameworkReference Include="Microsoft.AspNetCore.App"/>
+  </ItemGroup>
 
 </Project>

…nsions/Exception/MoryxExceptionFilter.cs …x.Asp.Extensions/MoryxExceptionFilter.cssrc/Moryx.Asp.Extensions/Exception/MoryxExceptionFilter.cs renamed to src/Moryx.Asp.Extensions/MoryxExceptionFilter.cs src/Moryx.Asp.Extensions/Exception/MoryxExceptionFilter.cs renamed to src/Moryx.Asp.Extensions/MoryxExceptionFilter.cs

@@ -12,7 +12,7 @@ public class MoryxExceptionFilter : IExceptionFilter
         public void OnException(ExceptionContext context)
         {
             context.HttpContext.Response.StatusCode = StatusCodes.Status500InternalServerError;
-            string headers = string.Join(" \r\n ", context.HttpContext.Request.Headers.Select(h => $"{h.Key}: {h.Value}"));
+            var headers = string.Join(" \r\n ", context.HttpContext.Request.Headers.Select(h => $"{h.Key}: {h.Value}"));
             context.Result = new ObjectResult(new MoryxExceptionResponse
             {
                 Title = "500 - Internal Server Error",

…ions/Exception/MoryxExceptionResponse.cs …Asp.Extensions/MoryxExceptionResponse.cssrc/Moryx.Asp.Extensions/Exception/MoryxExceptionResponse.cs renamed to src/Moryx.Asp.Extensions/MoryxExceptionResponse.cs src/Moryx.Asp.Extensions/Exception/MoryxExceptionResponse.cs renamed to src/Moryx.Asp.Extensions/MoryxExceptionResponse.cs

@@ -6,6 +6,7 @@ namespace Moryx.Asp.Extensions
     public class MoryxExceptionResponse
     {
         public string Title { get; set; }
+
         public string Exception { get; set; }
     }
 }

src/Moryx.ControlSystem.ProcessEngine/ModuleController/ComponentOrchestration.cs

@@ -2,7 +2,6 @@
 // Licensed under the Apache License, Version 2.0
 
 using Microsoft.Extensions.Logging;
-using Moryx.Communication.Endpoints;
 using Moryx.Container;
 using Moryx.ControlSystem.Jobs;
 using Moryx.ControlSystem.ProcessEngine.Jobs;
@@ -40,8 +39,6 @@ internal class ComponentOrchestration
 
         public ISetupJobHandler SetupManager { get; set; }
 
-        public IEndpointHostFactory HostFactory { get; set; }
-
         public IModuleLogger Logger { get; set; }
 
         #endregion

src/Moryx.Drivers.OpcUa/DataValueResult.cs

@@ -1,8 +1,7 @@
 // Copyright (c) 2025, Phoenix Contact GmbH & Co. KG
 
-using System;
+using Moryx.Tools;
 using Opc.Ua;
-using Moryx.Tools.FunctionResult;
 
 namespace Moryx.Drivers.OpcUa;
 

src/Moryx.Drivers.OpcUa/DriverStates/DriverOpcUaState.cs

@@ -1,11 +1,8 @@
 // Copyright (c) 2025, Phoenix Contact GmbH & Co. KG
 // Licensed under the Apache License, Version 2.0
 
-using System;
 using Moryx.AbstractionLayer.Drivers;
 using Moryx.StateMachines;
-using Moryx.Tools.FunctionResult;
-using Opc.Ua;
 using Opc.Ua.Client;
 
 namespace Moryx.Drivers.OpcUa.DriverStates;