Skip to content

Commit 6f30228

Browse files
committed
Finalized API of IMarkingLaserDriver
1 parent 9384a35 commit 6f30228

File tree

6 files changed

+9
-64
lines changed

6 files changed

+9
-64
lines changed

src/Moryx.AbstractionLayer/Drivers/Marking/IMarkingLaserDriver.cs

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,5 @@ public interface IMarkingLaserDriver : IDriver
1818
/// </summary>
1919
/// <param name="config">The configuration for the marking process.</param>
2020
Task<MarkingResponse> MarkAsync(MarkingConfiguration config);
21-
22-
/// <summary>
23-
/// Will be fired if an error occured
24-
/// </summary>
25-
event EventHandler<NotificationResponse> ErrorOccured;
26-
27-
/// <summary>
28-
/// Will be fired of a warning occured
29-
/// </summary>
30-
event EventHandler<NotificationResponse> WarningOccured;
3121
}
3222
}

src/Moryx.AbstractionLayer/Drivers/Marking/IMarkingLaserState.cs

Lines changed: 0 additions & 19 deletions
This file was deleted.

src/Moryx.AbstractionLayer/Drivers/Marking/MarkingConfiguration.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,15 +52,15 @@ public MarkingConfiguration()
5252
/// </summary>
5353
/// <param name="resizingFactor">The factor for resizing the marking file. 1 is original size.</param>
5454
/// <param name="angle">The angle of rotation in ° clockwise around the mid point of the image field. 0 is no rotation.</param>
55-
/// <param name="xaxis">Displacement along the X-axis in mm.</param>
56-
/// <param name="yaxis">Displacement along the Y-axis in mm.</param>
55+
/// <param name="xAxis">Displacement along the X-axis in mm.</param>
56+
/// <param name="yAxis">Displacement along the Y-axis in mm.</param>
5757
/// <returns>This object.</returns>
58-
public MarkingConfiguration SetTransformation(double resizingFactor, double angle, double xaxis, double yaxis)
58+
public MarkingConfiguration SetTransformation(double resizingFactor, double angle, double xAxis, double yAxis)
5959
{
6060
ResizingFactor = resizingFactor;
6161
Angle = angle;
62-
XAxis = xaxis;
63-
YAxis = yaxis;
62+
XAxis = xAxis;
63+
YAxis = yAxis;
6464
return this;
6565
}
6666
}

src/Moryx.AbstractionLayer/Drivers/Marking/MarkingFIleResponse.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ namespace Moryx.AbstractionLayer.Drivers.Marking
66
/// <summary>
77
/// Response of the marking file setup
88
/// </summary>
9-
public class MarkingFileResponse : TransmissionResult
9+
public class MarkingFileResponse : DriverResponse
1010
{
1111
/// <summary>
1212
/// Successful marking file setup
@@ -19,7 +19,7 @@ public MarkingFileResponse() : base()
1919
/// Faulty marking file setup
2020
/// </summary>
2121
/// <param name="errorMessage">Occured error</param>
22-
public MarkingFileResponse(string errorMessage) : base(new TransmissionError(errorMessage))
22+
public MarkingFileResponse(string errorMessage) : base(errorMessage)
2323
{
2424
}
2525
}

src/Moryx.AbstractionLayer/Drivers/Marking/MarkingResponse.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ namespace Moryx.AbstractionLayer.Drivers.Marking
66
/// <summary>
77
/// Response of the marking process
88
/// </summary>
9-
public class MarkingResponse : TransmissionResult
9+
public class MarkingResponse : DriverResponse
1010
{
1111
/// <summary>
1212
/// Successful marking
@@ -19,7 +19,7 @@ public MarkingResponse()
1919
/// Faulty marking
2020
/// </summary>
2121
/// <param name="errorMessage">Occured error</param>
22-
public MarkingResponse(string errorMessage) : base(new TransmissionError(errorMessage))
22+
public MarkingResponse(string errorMessage) : base(errorMessage)
2323
{
2424
}
2525
}

src/Moryx.AbstractionLayer/Drivers/Marking/NotificationResponse.cs

Lines changed: 0 additions & 26 deletions
This file was deleted.

0 commit comments

Comments
 (0)