Change to Interlocked.Increment

dacky179 · dacky179 · commit b6f5d0e0dc52 · 2025-07-25T09:04:05.000+02:00
diff --git a/src/Moryx/Threading/ParallelOperations.cs b/src/Moryx/Threading/ParallelOperations.cs
@@ -128,11 +128,8 @@ public int ScheduleExecution<T>(Action<T> operation, T userState, int delayMs, i
         /// </summary>
         public int ScheduleExecution<T>(Action<T> operation, T userState, int delayMs, int periodMs, bool criticalOperation) where T : class
         {
-            int id;
-            lock (_runningTimers)
-            {
-                id = ++_lastTimerId;
-            }
+            // thread safe increment of timer id
+            int id = Interlocked.Increment(ref _lastTimerId);
             
             var timer = new Timer(new NonStackingTimerCallback(state =>
             {

Original file line number	Diff line number	Diff line change
`@@ -128,11 +128,8 @@ public int ScheduleExecution<T>(Action<T> operation, T userState, int delayMs, i`
`128`	`128`	`/// </summary>`
`129`	`129`	`public int ScheduleExecution<T>(Action<T> operation, T userState, int delayMs, int periodMs, bool criticalOperation) where T : class`
`130`	`130`	`{`
`131`		`- int id;`
`132`		`- lock (_runningTimers)`
`133`		`- {`
`134`		`- id = ++_lastTimerId;`
`135`		`- }`
	`131`	`+ // thread safe increment of timer id`
	`132`	`+ int id = Interlocked.Increment(ref _lastTimerId);`
`136`	`133`
`137`	`134`	`var timer = new Timer(new NonStackingTimerCallback(state =>`
`138`	`135`	`{`