Apply PR comments

Author: seveneleven

README.md

@@ -87,9 +87,9 @@ introduced to manage template sources within a project.
 
 ### Usage
 
-    add <NAME> <URL> <BRANCH>    Adds a Git remote to the local config
-    remove <NAME>                Removes Git remotes
-    use <NAME>                   Uses the given remote by default
+    moryx remotes add <NAME> <URL> <BRANCH>    Adds a Git remote to the local config
+    moryx remotes remove <NAME>                Removes Git remotes
+    moryx remotes use <NAME>                   Uses the given remote by default
 
 ### Examples 
 

src/Moryx.Cli.Commands/Extensions/ConfigExtensions.cs

@@ -5,7 +5,7 @@ namespace Moryx.Cli.Commands.Extensions
 {
     public static class ConfigExtensions
     {
-        public static TemplateSettings AsTemplateSettings(this Config.Models.Configuration configuration, string dir, string solutionName, string profile = null)
+        public static TemplateSettings AsTemplateSettings(this Config.Models.Configuration configuration, string dir, string solutionName, string profile = "")
         {
             profile = string.IsNullOrEmpty(profile) ? configuration.DefaultProfile : profile;
             return new()

src/Moryx.Cli.Templates/Extensions/StringExtensions.cs

@@ -26,7 +26,7 @@ public static string ReplaceFileExtension(this string str, string oldStr, string
 
         public static string StateBase(this string str) => str + "StateBase";
 
-        public static string FileSystemCompatible(this string url)
+        public static string AsFolderName(this string url)
         {
             var pattern = @"[\:\/\?\#\[\]\!\$\&\'\(\)\*\+\,\;\=]";
             url = Regex.Replace(url, pattern, "_");

src/Moryx.Cli.Templates/Models/TemplateSettings.cs

@@ -10,7 +10,7 @@ public class TemplateSettings
         public required string AppName { get; set; }
         public string ProfileName { get; set; } = "default";
         public required string TargetDirectory { get; set; }
-        public string SourceDirectory { get => Path.Combine(TemplatesRoot(), Repository.FileSystemCompatible(), Branch); }
+        public string SourceDirectory { get => Path.Combine(TemplatesRoot(), Repository.AsFolderName(), Branch); }
 
 
         public string TemplatesRoot()

…li.Tests/FileSystemCompatibleUrlTests.cs …i.Tests/TemplateStringExtensionsTests.cssrc/Tests/Moryx.Cli.Tests/FileSystemCompatibleUrlTests.cs renamed to src/Tests/Moryx.Cli.Tests/TemplateStringExtensionsTests.cs src/Tests/Moryx.Cli.Tests/FileSystemCompatibleUrlTests.cs renamed to src/Tests/Moryx.Cli.Tests/TemplateStringExtensionsTests.cs

@@ -2,7 +2,7 @@
 
 namespace Moryx.Cli.Tests
 {
-    public class FileSystemCompatibleUrlTests
+    public class TemplateStringExtensionsTests
     {
 
         [SetUp]
@@ -14,7 +14,7 @@ public void Setup()
         [TestCase("ssh://[email protected]:microsoft/vscode.git", "[email protected]_microsoft_vscode.git")]
         public void CheckUrlConversion(string input, string expected)
         {
-            var result = input.FileSystemCompatible();
+            var result = input.AsFolderName();
 
             Assert.That(result, Is.EqualTo(expected));
         }