Composer: allow for PHPCS 4.0 + PHPCompatibility 10.0 #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As PHPCompatibility now has a `10.0.0-alpha1` tag available which is compatible with PHP_CodeSniffer 4.0, we can update the requirements. Includes tightening up the allowed version of the PHPCS Composer plugin as the `0.7` version is already five years old, so I don't think we still need allow for older versions. Note: ruleset adjustments to allow for PHPCompatibility 10 had already been made ahead of time via PRs 26, 51, 52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As PHPCompatibility now has a
10.0.0-alpha1tag available which is compatible with PHP_CodeSniffer 4.0, we can update the requirements.Includes tightening up the allowed version of the PHPCS Composer plugin as the
0.7version is already five years old, so I don't think we still need to allow for older versions.Note: ruleset adjustments to allow for PHPCompatibility 10 had already been made ahead of time via PRs #26, #51, #52