Merge pull request #49 from PHPCSStandards/feature/php8-compat-hardening

jrfnl · web-flow · commit 656492a8dc6f · 2020-10-03T03:33:41.000+02:00
QA: minor tweak
diff --git a/Scripts/CheckSniffCompleteness.php b/Scripts/CheckSniffCompleteness.php
@@ -258,7 +258,7 @@ protected function processCliCommand()
         foreach ($args as $arg) {
             if (\strpos($arg, '--exclude=') === 0) {
                 $exclude = \substr($arg, 10);
-                if ($exclude === '') {
+                if (empty($exclude)) {
                     $this->excludedDirs = [];
                     continue;
                 }

Original file line number	Diff line number	Diff line change
`@@ -258,7 +258,7 @@ protected function processCliCommand()`
`258`	`258`	`foreach ($args as $arg) {`
`259`	`259`	`if (\strpos($arg, '--exclude=') === 0) {`
`260`	`260`	`$exclude = \substr($arg, 10);`
`261`		`- if ($exclude === '') {`
	`261`	`+ if (empty($exclude)) {`
`262`	`262`	`$this->excludedDirs = [];`
`263`	`263`	`continue;`
`264`	`264`	`}`