Merge pull request #155 from PHPCSStandards/feature/filelist-constructor-should-not-return

jrfnl · web-flow · commit cf1a5bde9095 · 2024-09-10T01:53:39.000+02:00
FileList::__construct() should be a void method
diff --git a/Scripts/FileList.php b/Scripts/FileList.php
@@ -57,6 +57,8 @@ class FileList
      * @param string $directory The directory to examine.
      * @param string $rootPath  Path to the project root.
      * @param string $filter    PCRE regular expression to filter the file list with.
+     *
+     * @return void
      */
     public function __construct($directory, $rootPath = '', $filter = '')
     {
@@ -78,8 +80,6 @@ public function __construct($directory, $rootPath = '', $filter = '')
         }
 
         $this->fileIterator = new RegexIterator($flattened, $filter);
-
-        return $this;
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -57,6 +57,8 @@ class FileList`
`57`	`57`	`* @param string $directory The directory to examine.`
`58`	`58`	`* @param string $rootPath Path to the project root.`
`59`	`59`	`* @param string $filter PCRE regular expression to filter the file list with.`
	`60`	`+ *`
	`61`	`+ * @return void`
`60`	`62`	`*/`
`61`	`63`	`public function __construct($directory, $rootPath = '', $filter = '')`
`62`	`64`	`{`
`@@ -78,8 +80,6 @@ public function __construct($directory, $rootPath = '', $filter = '')`
`78`	`80`	`}`
`79`	`81`
`80`	`82`	`$this->fileIterator = new RegexIterator($flattened, $filter);`
`81`		`-`
`82`		`- return $this;`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`/**`