PHP 8.4 | BCFile|Variables::getMemberProperties(): sync with PHPCS 3.13.3 / handle abstract properties

Refs:
* https://wiki.php.net/rfc/property-hooks#abstract_properties
* PHPCSStandards/PHP_CodeSniffer 1184

Author: jrfnl

PHPCSUtils/BackCompat/BCFile.php

@@ -559,6 +559,7 @@ public static function getMethodProperties(File $phpcsFile, $stackPtr)
      *   'is_static'       => boolean,       // TRUE if the static keyword was found.
      *   'is_readonly'     => boolean,       // TRUE if the readonly keyword was found.
      *   'is_final'        => boolean,       // TRUE if the final keyword was found.
+     *   'is_abstract'     => boolean,       // TRUE if the abstract keyword was found.
      *   'type'            => string,        // The type of the var (empty if no type specified).
      *   'type_token'      => integer|false, // The stack pointer to the start of the type
      *                                       // or FALSE if there is no type.
@@ -573,13 +574,16 @@ public static function getMethodProperties(File $phpcsFile, $stackPtr)
      *
      * Changelog for the PHPCS native function:
      * - Introduced in PHPCS 0.0.5.
+     * - PHPCS 3.13.3: support for PHP 8.4 abstract properties.
      * - PHPCS 4.0: properties in interfaces (PHP 8.4+) are accepted.
      * - PHPCS 4.0: will no longer throw a parse error warning.
      *
      * @see \PHP_CodeSniffer\Files\File::getMemberProperties() Original source.
      * @see \PHPCSUtils\Utils\Variables::getMemberProperties() PHPCSUtils native improved version.
      *
      * @since 1.0.0
+     * @since 1.1.0 Sync with PHPCS 4.0.0, remove parse error warning and support PHP 8.4 properties in interfaces. PHPCS(new)#991
+     * @since 1.1.2 Sync with PHPCS 3.13.3, support for abstract properties. PHPCS(new)#xxx
      *
      * @param \PHP_CodeSniffer\Files\File $phpcsFile The file being scanned.
      * @param int                         $stackPtr  The position in the stack of the `T_VARIABLE` token to
@@ -626,6 +630,7 @@ public static function getMemberProperties(File $phpcsFile, $stackPtr)
             T_VAR      => T_VAR,
             T_READONLY => T_READONLY,
             T_FINAL    => T_FINAL,
+            T_ABSTRACT => T_ABSTRACT,
         ];
 
         $valid += Tokens::$scopeModifiers;
@@ -637,6 +642,7 @@ public static function getMemberProperties(File $phpcsFile, $stackPtr)
         $isStatic       = false;
         $isReadonly     = false;
         $isFinal        = false;
+        $isAbstract     = false;
 
         $startOfStatement = $phpcsFile->findPrevious(
             [
@@ -684,6 +690,9 @@ public static function getMemberProperties(File $phpcsFile, $stackPtr)
                 case T_FINAL:
                     $isFinal = true;
                     break;
+                case T_ABSTRACT:
+                    $isAbstract = true;
+                    break;
             }
         }
 
@@ -728,6 +737,7 @@ public static function getMemberProperties(File $phpcsFile, $stackPtr)
             'is_static'       => $isStatic,
             'is_readonly'     => $isReadonly,
             'is_final'        => $isFinal,
+            'is_abstract'     => $isAbstract,
             'type'            => $type,
             'type_token'      => $typeToken,
             'type_end_token'  => $typeEndToken,

PHPCSUtils/Utils/Variables.php

@@ -108,6 +108,7 @@ final class Variables
      *                 'is_static'       => boolean,       // TRUE if the static keyword was found.
      *                 'is_readonly'     => boolean,       // TRUE if the readonly keyword was found.
      *                 'is_final'        => boolean,       // TRUE if the final keyword was found.
+     *                 'is_abstract'     => boolean,       // TRUE if the abstract keyword was found.
      *                 'type'            => string,        // The type of the var (empty if no type specified).
      *                 'type_token'      => integer|false, // The stack pointer to the start of the type
      *                                                     // or FALSE if there is no type.
@@ -155,6 +156,7 @@ public static function getMemberProperties(File $phpcsFile, $stackPtr)
         $isStatic       = false;
         $isReadonly     = false;
         $isFinal        = false;
+        $isAbstract     = false;
 
         $startOfStatement = $phpcsFile->findPrevious(
             [
@@ -211,6 +213,9 @@ public static function getMemberProperties(File $phpcsFile, $stackPtr)
                 case \T_FINAL:
                     $isFinal = true;
                     break;
+                case \T_ABSTRACT:
+                    $isAbstract = true;
+                    break;
             }
         }
 
@@ -254,6 +259,7 @@ public static function getMemberProperties(File $phpcsFile, $stackPtr)
             'is_static'       => $isStatic,
             'is_readonly'     => $isReadonly,
             'is_final'        => $isFinal,
+            'is_abstract'     => $isAbstract,
             'type'            => $type,
             'type_token'      => $typeToken,
             'type_end_token'  => $typeEndToken,

Tests/BackCompat/BCFile/GetMemberPropertiesTest.inc

@@ -401,3 +401,27 @@ class AsymVisibility {
     /* testPHP84IllegalAsymPublicProtectedSetStaticProperty */
     public protected(set) static mixed $prop10;
 }
+
+abstract class WithAbstractProperties {
+    /* testPHP84AbstractPublicTypedProp */
+    abstract public string $val1 { get; }
+    /* testPHP84AbstractProtectedTypedProp */
+    abstract protected Union|Type $val2 { set; }
+    /* testPHP84AbstractMiddleTypedProp */
+    public abstract Intersection&Type $val3 { get; }
+    /* testPHP84AbstractImplicitVisibilityTypedProp */
+    abstract int $val4 { set; }
+    /* testPHP84AbstractImplicitVisibilityProp */
+    abstract $val5 { get; }
+    /* testPHP84AbstractNullableTypedProp */
+    abstract public ?string $val6 { set; }
+    /* testPHP84AbstractComplexTypedProp */
+    abstract protected (Foo&\Bar)|false $val7 { get; }
+
+    /* testPHP84IllegalAbstractPrivateProp */
+    private abstract string $val8 { get; }
+    /* testPHP84IllegalAbstractReadonlyProp */
+    public readonly abstract string $val9 { get; }
+    /* testPHP84IllegalAbstractStaticProp */
+    public abstract static string $val10 { get; }
+}