Merge pull request #451 from PHPCSStandards/backcompat/getdeclarationname-add-extra-tests

[BackCompat|ObjectDeclarations]::get[Declaration]Name(): add extra tests

Author: jrfnl

Tests/BackCompat/BCFile/GetDeclarationNameTest.inc

@@ -85,6 +85,9 @@ enum Hoo : string
 /* testBackedEnumNoSpaceBetweenNameAndColon */
 enum Suit: int implements Colorful, CardGame {}
 
+/* testFunctionReturnByRefWithReservedKeywordEach */
+function &each() {}
+
 /* testLiveCoding */
 // Intentional parse error. This has to be the last test in the file.
 function // Comment.

Tests/BackCompat/BCFile/GetDeclarationNameTest.php

@@ -192,6 +192,10 @@ public function dataGetDeclarationName()
                 '/* testBackedEnumNoSpaceBetweenNameAndColon */',
                 'Suit',
             ],
+            'function-return-by-reference-with-reserved-keyword-each' => [
+                '/* testFunctionReturnByRefWithReservedKeywordEach */',
+                'each',
+            ],
         ];
     }
 }

Tests/Utils/ObjectDeclarations/GetNameDiffTest.inc

@@ -12,6 +12,15 @@ interface switch{ // Intentional parse error.
     public function someFunction();
 }
 
+/* testFunctionReturnByRefWithReservedKeywordParent */
+function &parent() {}
+
+/* testFunctionReturnByRefWithReservedKeywordSelf */
+function &self() {}
+
+/* testFunctionReturnByRefWithReservedKeywordStatic */
+function &static() {}
+
 /* testLiveCoding */
 // Intentional parse error. Redundancy testing.
 abstract class

Tests/Utils/ObjectDeclarations/GetNameDiffTest.php

@@ -117,6 +117,18 @@ public function dataGetName()
                 'testMarker' => '/* testInvalidInterfaceName */',
                 'expected'   => 'switch',
             ],
+            'function-return-by-reference-with-reserved-keyword-parent' => [
+                '/* testFunctionReturnByRefWithReservedKeywordParent */',
+                'parent',
+            ],
+            'function-return-by-reference-with-reserved-keyword-self' => [
+                '/* testFunctionReturnByRefWithReservedKeywordSelf */',
+                'self',
+            ],
+            'function-return-by-reference-with-reserved-keyword-static' => [
+                '/* testFunctionReturnByRefWithReservedKeywordStatic */',
+                'static',
+            ],
         ];
     }
 }