Merge pull request #735 from PHPCSStandards/develop

Release 1.2.1

Author: jrfnl

CHANGELOG.md

@@ -10,6 +10,17 @@ This projects adheres to [Keep a CHANGELOG](https://keepachangelog.com/) and use
 _Nothing yet._
 
 
+## [1.2.1] - 2025-11-17
+
+### Fixed
+
+#### Abstract Sniffs
+
+* The `AbstractArrayDeclarationSniff::getActualArrayKey()` method could cause deprecation notices and even fatal errors, when a PHPCS scan would be run on a different PHP version than the "code under scan" is targetting and the "code under scan" contained deprecated/removed type casts. [#733]
+
+[#733]: https://github.com/PHPCSStandards/PHPCSUtils/pull/733
+
+
 ## [1.2.0] - 2025-11-11
 
 ### Added
@@ -30,7 +41,7 @@ _Nothing yet._
 
 #### Other
 
-* Dropped support for [PHP_CodeSniffer] < 3.13.5/<4.00. [#729]
+* Dropped support for [PHP_CodeSniffer] < 3.13.5/4.0.1. [#729]
     Please ensure you run `composer update phpcsstandards/phpcsutils --with-dependencies` to benefit from this.
 * Various housekeeping.
 
@@ -1322,6 +1333,7 @@ This initial alpha release contains the following utility classes:
 
 
 [Unreleased]:   https://github.com/PHPCSStandards/PHPCSUtils/compare/stable...HEAD
+[1.2.1]:        https://github.com/PHPCSStandards/PHPCSUtils/compare/1.2.0...1.2.1
 [1.2.0]:        https://github.com/PHPCSStandards/PHPCSUtils/compare/1.1.3...1.2.0
 [1.1.3]:        https://github.com/PHPCSStandards/PHPCSUtils/compare/1.1.2...1.1.3
 [1.1.2]:        https://github.com/PHPCSStandards/PHPCSUtils/compare/1.1.1...1.1.2

PHPCSUtils/AbstractSniffs/AbstractArrayDeclarationSniff.php

@@ -493,7 +493,9 @@ public function getActualArrayKey(File $phpcsFile, $startPtr, $endPtr)
                 }
             }
 
-            if (isset($this->acceptedTokens[$this->tokens[$i]['code']]) === false) {
+            if (isset($this->acceptedTokens[$this->tokens[$i]['code']]) === false
+                || \T_UNSET_CAST === $this->tokens[$i]['code']
+            ) {
                 // This is not a key we can evaluate. Might be a variable or constant.
                 return;
             }
@@ -506,6 +508,40 @@ public function getActualArrayKey(File $phpcsFile, $startPtr, $endPtr)
                 continue;
             }
 
+            /*
+             * Make sure that when new/deprecated/removed casts are used in the code under scan and the sniff is run
+             * on a PHP version which doesn't support the cast, the eval() won't cause a deprecation notice,
+             * borking the scan of the file.
+             *
+             * - (unset) was deprecated in PHP 7.2 and removed in PHP 8.0;
+             * - (real) was deprecated in PHP 7.4 and removed in PHP 8.0;
+             * - (boolean) was deprecated in PHP 8.5 and will be removed in PHP 9.0;
+             * - (integer) was deprecated in PHP 8.5 and will be removed in PHP 9.0;
+             * - (double) was deprecated in PHP 8.5 and will be removed in PHP 9.0;
+             * - (string) was deprecated in PHP 8.5 and will be removed in PHP 9.0;
+             */
+            if (\T_DOUBLE_CAST === $this->tokens[$i]['code']) {
+                $content .= '(float)';
+                continue;
+            }
+
+            if (\PHP_VERSION_ID >= 80500) {
+                if (\T_INT_CAST === $this->tokens[$i]['code']) {
+                    $content .= '(int)';
+                    continue;
+                }
+
+                if (\T_BOOL_CAST === $this->tokens[$i]['code']) {
+                    $content .= '(bool)';
+                    continue;
+                }
+
+                if (\T_BINARY_CAST === $this->tokens[$i]['code']) {
+                    $content .= '(string)';
+                    continue;
+                }
+            }
+
             // Account for heredoc with vars.
             if ($this->tokens[$i]['code'] === \T_START_HEREDOC) {
                 $text = TextStrings::getCompleteTextString($phpcsFile, $i);

Tests/AbstractSniffs/AbstractArrayDeclaration/GetActualArrayKeyTest.inc

@@ -26,6 +26,7 @@ EOD
 $var text
 EOD
                                 => 'excluded',
+    (unset) false               => 'excluded', // Type cast deprecated per PHP 7.2, removed 8.0.
 ];
 
 /* testAllEmptyString */
@@ -34,6 +35,7 @@ $emptyStringKey = array(
     null           => 'null',
     (string) false => 'false',
     \null          => 'null',
+    (binary) false => 'binary false', // Type cast deprecated per PHP 8.5.
 );
 
 /* testAllZero */
@@ -61,6 +63,10 @@ $everythingZero = [
     (true) ? 0 : 1   => 't',
     ! true           => 'u',
     \false           => 'v',
+    (integer) ''     => 'w', // Type cast deprecated per PHP 8.5.
+    (float) 0.14     => 'x',
+    (real) 0.2       => 'y', // Type cast deprecated per PHP 7.4, removed 8.0.
+    (double) 0.005   => 'z', // Type cast deprecated per PHP 8.5.
 ];
 
 /* testAllOne */
@@ -89,6 +95,11 @@ $everythingOne = [
     ! false          => 't',
     (string) true    => 'u',
     \true            => 'v',
+    (boolean) 1      => 'w',  // Type cast deprecated per PHP 8.5.
+    (binary) true    => 'x',
+    (float) 1.14     => 'y',
+    (real) 1.2       => 'z',  // Type cast deprecated per PHP 7.4, removed 8.0.
+    (double) 1.005   => 'aa', // Type cast deprecated per PHP 8.5.
 ];
 
 /* testAllEleven */
@@ -110,6 +121,7 @@ $everythingEleven = [
     "11"               => 'o',
     11.                => 'p',
     35 % 12            => 'q',
+    (integer) '11'     => 'r', // Type cast deprecated per PHP 8.5.
 ];
 
 /* testAllStringAbc */