PHP 8.5 | Fix another runtime deprecation notice

This fixes yet another "Using null as an array offset" deprecation notice on PHP 8.5. This one only occurred on PHPCS 4.0, not on 3.x.

The tests for this fix have been pulled in 1225 (to safeguard that the issue doesn't exist in 3.x) and merged up into the 4.x branch.

Note: as the `if` condition was pretty complex, I've done a small refactor to make the code more readable and understandable.

Author: jrfnl

src/Tokenizers/PHP.php

@@ -2139,15 +2139,25 @@ protected function tokenize($string)
                         continue;
                     }
 
-                    if (($tokenType !== T_CALLABLE
-                        && isset($lastRelevantNonEmpty) === false)
-                        || ($lastRelevantNonEmpty === T_ARRAY
-                        && $tokenType === '(')
-                        || (isset(Tokens::NAME_TOKENS[$lastRelevantNonEmpty]) === true
-                        && ($tokenType === T_DOUBLE_COLON
-                        || $tokenType === '('
-                        || $tokenType === ':'))
-                    ) {
+                    $isInlineThen = false;
+                    if (isset($lastRelevantNonEmpty) === false && $tokenType !== T_CALLABLE) {
+                        // Can be anything, but is definitely not a type declaration.
+                        $isInlineThen = true;
+                    } else if (isset($lastRelevantNonEmpty) === true) {
+                        if ($lastRelevantNonEmpty === T_ARRAY && $tokenType === '(') {
+                            // Array declaration in ternary then.
+                            $isInlineThen = true;
+                        } else if (isset(Tokens::NAME_TOKENS[$lastRelevantNonEmpty]) === true
+                            && ($tokenType === T_DOUBLE_COLON
+                            || $tokenType === '('
+                            || $tokenType === ':')
+                        ) {
+                            // Constant access, function call, static class member access in ternary then.
+                            $isInlineThen = true;
+                        }
+                    }
+
+                    if ($isInlineThen === true) {
                         if (PHP_CODESNIFFER_VERBOSITY > 1) {
                             StatusWriter::write("* token $stackPtr changed from ? to T_INLINE_THEN", 2);
                         }