Squiz/FunctionDeclarationArgumentSpacing: bug fix / SpaceBeforeEquals + SpaceAfterEquals do not flag new lines for spacing 0

A `T_WHITESPACE` token only containing new line characters will have its token `'length'` set to `0`.

This means that if there was a new line before/after the equal sign and the `$equalsSpacing` property was set to the default value of `0`, the sniff would not report it.
When the `$equalsSpacing` property was set to `1`, the sniff already flagged this correctly (though there are other problems with that in the fixer - see later commit).

Fixed now.

Includes tests.

Author: jrfnl

src/Standards/Squiz/Sniffs/Functions/FunctionDeclarationArgumentSpacingSniff.php

@@ -202,7 +202,9 @@ public function processBracket($phpcsFile, $openBracket)
                 $equalToken = $param['default_equal_token'];
 
                 $spacesBefore = 0;
-                if (($equalToken - $param['token']) > 1) {
+                if ($tokens[$param['token']]['line'] !== $tokens[$equalToken]['line']) {
+                    $spacesBefore = 'newline';
+                } else if ($tokens[($param['token'] + 1)]['code'] === T_WHITESPACE) {
                     $spacesBefore = $tokens[($param['token'] + 1)]['length'];
                 }
 
@@ -225,7 +227,9 @@ public function processBracket($phpcsFile, $openBracket)
                 }//end if
 
                 $spacesAfter = 0;
-                if ($tokens[($equalToken + 1)]['code'] === T_WHITESPACE) {
+                if ($tokens[$equalToken]['line'] !== $tokens[$param['default_token']]['line']) {
+                    $spacesAfter = 'newline';
+                } else if ($tokens[($equalToken + 1)]['code'] === T_WHITESPACE) {
                     $spacesAfter = $tokens[($equalToken + 1)]['length'];
                 }
 

src/Standards/Squiz/Tests/Functions/FunctionDeclarationArgumentSpacingUnitTest.inc

@@ -142,3 +142,11 @@ function newlineAfterVariadicFixerRespectsComment(
     //comment
     $param
 ) {}
+
+function newlineBeforeAndAfterEqualsSignShouldBeFixedForSpacing0(
+    $param
+
+        =
+
+    true
+) {}

src/Standards/Squiz/Tests/Functions/FunctionDeclarationArgumentSpacingUnitTest.inc.fixed

@@ -131,3 +131,7 @@ function newlineAfterVariadicFixerRespectsComment(
     ...//comment
     $param
 ) {}
+
+function newlineBeforeAndAfterEqualsSignShouldBeFixedForSpacing0(
+    $param=true
+) {}

src/Standards/Squiz/Tests/Functions/FunctionDeclarationArgumentSpacingUnitTest.php

@@ -74,6 +74,7 @@ public function getErrorList()
             129 => 1,
             135 => 1,
             141 => 1,
+            149 => 2,
         ];
 
     }//end getErrorList()