Squiz/ComparisonOperatorUsage: handle FQN true/false/null

jrfnl · jrfnl · commit 1068518413a5 · 2025-08-30T12:09:34.000+02:00
This commit fixes the sniff to handle "fully qualified true/false" the same as unqualified true/false.

Includes tests.
diff --git a/src/Standards/Squiz/Tests/Operators/ComparisonOperatorUsageUnitTest.inc b/src/Standards/Squiz/Tests/Operators/ComparisonOperatorUsageUnitTest.inc
@@ -136,3 +136,9 @@ if (empty($argTags > 0)) {
 }
 
 myFunction($var1 === true ? "" : "foobar");
+
+// Verify that FQN true/false are handled the same as unqualified.
+if (true) {}
+if (\true) {}
+for ($var1 = 10; FALSE; $var1--) {}
+for ($var1 = 10; \FALSE; $var1--) {}

Original file line number	Diff line number	Diff line change
`@@ -136,3 +136,9 @@ if (empty($argTags > 0)) {`
`136`	`136`	`}`
`137`	`137`
`138`	`138`	`myFunction($var1 === true ? "" : "foobar");`
	`139`	`+`
	`140`	`+// Verify that FQN true/false are handled the same as unqualified.`
	`141`	`+if (true) {}`
	`142`	`+if (\true) {}`
	`143`	`+for ($var1 = 10; FALSE; $var1--) {}`
	`144`	`+for ($var1 = 10; \FALSE; $var1--) {}`