Commit 12fab63
committed
RuleInclusion*Test: remove a few redundant assertions
These assertions are checking whether explicitly declared properties exist, which is redundant.
Removing the assertions does not diminish the value of the tests as there are follow-up assertions testing the value of the properties.
Removing the assertions also gets rid of a warning thrown in PHPUnit 9.6.x about the `assertObjectHasAttribute()` assertion being removed in PHPUnit 10.0.
Note: PHPUnit 10.1.0 adds these assertions back again, but under a different name `assertObjectHasProperty()`.1 parent 48c8f69 commit 12fab63
File tree
3 files changed
+0
-5
lines changed- tests/Core/Ruleset
3 files changed
+0
-5
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
91 | 91 | | |
92 | 92 | | |
93 | 93 | | |
94 | | - | |
95 | 94 | | |
96 | 95 | | |
97 | 96 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
92 | 92 | | |
93 | 93 | | |
94 | 94 | | |
95 | | - | |
96 | 95 | | |
97 | 96 | | |
98 | 97 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
91 | 91 | | |
92 | 92 | | |
93 | 93 | | |
94 | | - | |
95 | 94 | | |
96 | 95 | | |
97 | 96 | | |
| |||
336 | 335 | | |
337 | 336 | | |
338 | 337 | | |
339 | | - | |
340 | 338 | | |
341 | 339 | | |
342 | 340 | | |
| |||
426 | 424 | | |
427 | 425 | | |
428 | 426 | | |
429 | | - | |
430 | 427 | | |
431 | 428 | | |
432 | 429 | | |
| |||
0 commit comments