Squiz/FunctionDeclarationArgumentSpacing: bug fix / SpacingAfterVariadic does not flag new lines

A `T_WHITESPACE` token only containing new line characters will have its token `'length'` set to `0`.

This means that if there was a new line after an ellipsis token, the sniff would not report it.

Fixed now.

Also note that, as the sniff demands no whitespace after a reference operator, we don't need the extra check for `$gap !== 0` as we already know that the next token is a whitespace token and needs to be flagged.

Includes test.

Author: jrfnl

src/Standards/Squiz/Sniffs/Functions/FunctionDeclarationArgumentSpacingSniff.php

@@ -175,12 +175,12 @@ public function processBracket($phpcsFile, $openBracket)
             if ($param['variable_length'] === true) {
                 $variadicToken = $param['variadic_token'];
 
-                $gap = 0;
                 if ($tokens[($variadicToken + 1)]['code'] === T_WHITESPACE) {
                     $gap = $tokens[($variadicToken + 1)]['length'];
-                }
+                    if ($tokens[$variadicToken]['line'] !== $tokens[($variadicToken + 2)]['line']) {
+                        $gap = 'newline';
+                    }
 
-                if ($gap !== 0) {
                     $error = 'Expected 0 spaces after variadic operator for argument "%s"; %s found';
                     $data  = [
                         $param['name'],

src/Standards/Squiz/Tests/Functions/FunctionDeclarationArgumentSpacingUnitTest.inc

@@ -130,3 +130,15 @@ function newlineAfterReferenceFixerRespectsComment(
     // comment
     $param
 ) {}
+
+function newlineAfterVariadicShouldBeFlaggedAndFixed(
+    ...
+
+    $param
+) {}
+
+function newlineAfterVariadicFixerRespectsComment(
+    ...
+    //comment
+    $param
+) {}

src/Standards/Squiz/Tests/Functions/FunctionDeclarationArgumentSpacingUnitTest.inc.fixed

@@ -122,3 +122,12 @@ function newlineAfterReferenceFixerRespectsComment(
     &// comment
     $param
 ) {}
+
+function newlineAfterVariadicShouldBeFlaggedAndFixed(
+    ...$param
+) {}
+
+function newlineAfterVariadicFixerRespectsComment(
+    ...//comment
+    $param
+) {}

src/Standards/Squiz/Tests/Functions/FunctionDeclarationArgumentSpacingUnitTest.php

@@ -72,6 +72,8 @@ public function getErrorList()
             117 => 1,
             123 => 1,
             129 => 1,
+            135 => 1,
+            141 => 1,
         ];
 
     }//end getErrorList()