Generic/OpeningFunctionBraceKernighanRichie: improve test coverage

Includes removing unnecessary trailing spaces from empty lines in the test file.

Author: rodrigoprimo

src/Standards/Generic/Tests/Functions/OpeningFunctionBraceKernighanRitchieUnitTest.1.inc

@@ -23,16 +23,16 @@ class myClass
     // Good.
     function myFunction() {
     }
-    
+
     // Brace should be on same line.
     function myFunction()
     {
     }
-    
+
     // Too many spaces.
     function myFunction()   {
     }
-    
+
     // Uses tab.
     function myFunction()	{
     }
@@ -70,18 +70,18 @@ class myClass
     function myFunction($variable1, $variable2,
         $variable3, $variable4) {
     }
-    
+
     // Brace should be on same line.
     function myFunction($variable1, $variable2,
         $variable3, $variable4)
     {
     }
-    
+
     // Too many spaces.
     function myFunction($variable1, $variable2,
         $variable3, $variable4)   {
     }
-    
+
     // Uses tab.
     function myFunction($variable1, $variable2,
         $variable3, $variable4)	{
@@ -212,3 +212,21 @@ function myFunction($a, $lot, $of, $params)
 function myFunction() {}
 function myFunction()      {} // Too many spaces with an empty function.
 function myFunction()	{} // Too many spaces (tab) with an empty function.
+
+// phpcs:set Generic.Functions.OpeningFunctionBraceKernighanRitchie checkFunctions 0
+function shouldBeIgnored()
+{}
+// phpcs:set Generic.Functions.OpeningFunctionBraceKernighanRitchie checkFunctions 1
+
+function dnfReturnType(): (Response&SuccessResponse)|AnotherResponse|string
+{}
+
+function commentAfterOpeningBrace() { // Some comment.
+}
+
+function variableAssignmentAfterOpeningBrace() { $a = 1;
+}
+
+abstract class MyClass {
+    abstract public function abstractMethod();
+}

src/Standards/Generic/Tests/Functions/OpeningFunctionBraceKernighanRitchieUnitTest.1.inc.fixed

@@ -22,15 +22,15 @@ class myClass
     // Good.
     function myFunction() {
     }
-    
+
     // Brace should be on same line.
     function myFunction() {
     }
-    
+
     // Too many spaces.
     function myFunction() {
     }
-    
+
     // Uses tab.
     function myFunction() {
     }
@@ -67,17 +67,17 @@ class myClass
     function myFunction($variable1, $variable2,
         $variable3, $variable4) {
     }
-    
+
     // Brace should be on same line.
     function myFunction($variable1, $variable2,
         $variable3, $variable4) {
     }
-    
+
     // Too many spaces.
     function myFunction($variable1, $variable2,
         $variable3, $variable4) {
     }
-    
+
     // Uses tab.
     function myFunction($variable1, $variable2,
         $variable3, $variable4) {
@@ -200,3 +200,23 @@ function myFunction($a, $lot, $of, $params)
 function myFunction() {}
 function myFunction() {} // Too many spaces with an empty function.
 function myFunction() {} // Too many spaces (tab) with an empty function.
+
+// phpcs:set Generic.Functions.OpeningFunctionBraceKernighanRitchie checkFunctions 0
+function shouldBeIgnored()
+{}
+// phpcs:set Generic.Functions.OpeningFunctionBraceKernighanRitchie checkFunctions 1
+
+function dnfReturnType(): (Response&SuccessResponse)|AnotherResponse|string {
+}
+
+function commentAfterOpeningBrace() {
+ // Some comment.
+}
+
+function variableAssignmentAfterOpeningBrace() {
+ $a = 1;
+}
+
+abstract class MyClass {
+    abstract public function abstractMethod();
+}

src/Standards/Generic/Tests/Functions/OpeningFunctionBraceKernighanRitchieUnitTest.2.inc

@@ -0,0 +1,11 @@
+<?php
+
+// Tests with tabs and the tabWidth config set to 4.
+
+// Uses one tab.
+function myFunction()	{
+}
+
+// Uses three tabs.
+function myFunction()			{
+}

src/Standards/Generic/Tests/Functions/OpeningFunctionBraceKernighanRitchieUnitTest.2.inc.fixed

@@ -0,0 +1,11 @@
+<?php
+
+// Tests with tabs and the tabWidth config set to 4.
+
+// Uses one tab.
+function myFunction() {
+}
+
+// Uses three tabs.
+function myFunction() {
+}

src/Standards/Generic/Tests/Functions/OpeningFunctionBraceKernighanRitchieUnitTest.3.inc

@@ -0,0 +1,7 @@
+<?php
+
+// Intentional parse error (missing opening curly brace).
+// This should be the only test in this file.
+// Testing that the sniff is *not* triggered.
+
+function missingOpeningCurlyBrace()

src/Standards/Generic/Tests/Functions/OpeningFunctionBraceKernighanRitchieUnitTest.php

@@ -20,6 +20,23 @@ final class OpeningFunctionBraceKernighanRitchieUnitTest extends AbstractSniffUn
 {
 
 
+    /**
+     * Get a list of CLI values to set before the file is tested.
+     *
+     * @param string                  $testFile The name of the file being tested.
+     * @param \PHP_CodeSniffer\Config $config   The config data for the test run.
+     *
+     * @return void
+     */
+    public function setCliValues($testFile, $config)
+    {
+        if ($testFile === 'OpeningFunctionBraceKernighanRitchieUnitTest.2.inc') {
+            $config->tabWidth = 4;
+        }
+
+    }//end setCliValues()
+
+
     /**
      * Returns the lines where errors should occur.
      *
@@ -63,6 +80,14 @@ public function getErrorList($testFile='')
                 203 => 1,
                 213 => 1,
                 214 => 1,
+                222 => 1,
+                224 => 1,
+                227 => 1,
+            ];
+        case 'OpeningFunctionBraceKernighanRitchieUnitTest.2.inc':
+            return [
+                6  => 1,
+                10 => 1,
             ];
         default:
             return [];