Merge pull request #330 from PHPCSStandards/php-8.3/generic-lowercaseconstant-support-typed-constants

PHP 8.3 | Generic/LowerCaseConstant: add support for typed constants

Author: jrfnl

src/Standards/Generic/Sniffs/PHP/LowerCaseConstantSniff.php

@@ -81,6 +81,9 @@ public function register()
         $targets[] = T_CLOSURE;
         $targets[] = T_FN;
 
+        // Register constant keyword to filter out type declarations.
+        $targets[] = T_CONST;
+
         return $targets;
 
     }//end register()
@@ -101,6 +104,19 @@ public function process(File $phpcsFile, $stackPtr)
     {
         $tokens = $phpcsFile->getTokens();
 
+        // Skip over potential type declarations for constants.
+        if ($tokens[$stackPtr]['code'] === T_CONST) {
+            // Constant must always have a value assigned to it, so we can just look for the assignment
+            // operator. Anything between the const keyword and the assignment can be safely ignored.
+            $skipTo = $phpcsFile->findNext(T_EQUAL, ($stackPtr + 1));
+            if ($skipTo !== false) {
+                return $skipTo;
+            }
+
+            // If we're at the end of the file, just return.
+            return;
+        }
+
         /*
          * Skip over type declarations for properties.
          *

src/Standards/Generic/Tests/PHP/LowerCaseConstantUnitTest.inc

@@ -144,6 +144,14 @@ readonly class Properties {
     }
 }
 
+// PHP 8.3 introduces typed constants.
+class TypedConstants {
+    const MyClass|NULL|TRUE|FALSE MYCONST = FALSE;
+}
+
+// Global constants can not be typed.
+const MYCONST = TRUE;
+
 // Last coding/parse error.
 // This has to be the last test in the file.
 function UnclosedCurly (): FALSE {

src/Standards/Generic/Tests/PHP/LowerCaseConstantUnitTest.inc.fixed

@@ -144,6 +144,14 @@ readonly class Properties {
     }
 }
 
+// PHP 8.3 introduces typed constants.
+class TypedConstants {
+    const MyClass|NULL|TRUE|FALSE MYCONST = false;
+}
+
+// Global constants can not be typed.
+const MYCONST = true;
+
 // Last coding/parse error.
 // This has to be the last test in the file.
 function UnclosedCurly (): FALSE {

src/Standards/Generic/Tests/PHP/LowerCaseConstantUnitTest.php

@@ -64,6 +64,8 @@ public function getErrorList($testFile='')
                 121 => 1,
                 125 => 1,
                 129 => 1,
+                149 => 1,
+                153 => 1,
             ];
 
         case 'LowerCaseConstantUnitTest.js':