Squiz/MemberVarSpacing: bug fix - don't remove blank attribute lines

While blank lines between the docblock and the property declaration should be removed, blank lines _within_ an attribute should be ignored as that's for a sniff dealing with attribute spacing to deal with and is outside of the scope of this sniff.

Fixed now.

Includes updated test.

Author: jrfnl

src/Standards/Squiz/Sniffs/WhiteSpace/MemberVarSpacingSniff.php

@@ -94,6 +94,11 @@ protected function processMemberVar(File $phpcsFile, $stackPtr)
 
         // Check for blank lines between the docblock/comment and the property declaration.
         for ($i = ($start + 1); $i < $startOfStatement; $i++) {
+            if (isset($tokens[$i]['attribute_closer']) === true) {
+                $i = $tokens[$i]['attribute_closer'];
+                continue;
+            }
+
             if ($tokens[$i]['column'] !== 1
                 || $tokens[$i]['code'] !== T_WHITESPACE
                 || $tokens[$i]['line'] === $tokens[($i + 1)]['line']

src/Standards/Squiz/Tests/WhiteSpace/MemberVarSpacingUnitTest.1.inc

@@ -395,7 +395,11 @@ class MultipleBlankLinesInPreAmble {
     #[MyAttribute]
 
 
-    #[MyOtherAttribute]
+    #[
+
+        BlankLinesWithinAnAttributeShouldBeLeftAlone
+
+    ]
 
     public $prop;
 }

src/Standards/Squiz/Tests/WhiteSpace/MemberVarSpacingUnitTest.1.inc.fixed

@@ -382,7 +382,11 @@ class MultipleBlankLinesInPreAmble {
      * Docblock.
      */
     #[MyAttribute]
-    #[MyOtherAttribute]
+    #[
+
+        BlankLinesWithinAnAttributeShouldBeLeftAlone
+
+    ]
     public $prop;
 }
 

src/Standards/Squiz/Tests/WhiteSpace/MemberVarSpacingUnitTest.php

@@ -79,10 +79,10 @@ public function getErrorList($testFile='')
                 384 => 1,
                 394 => 1,
                 396 => 1,
-                399 => 1,
-                408 => 1,
-                411 => 1,
+                403 => 1,
                 412 => 1,
+                415 => 1,
+                416 => 1,
             ];
 
         default: