Skip to content

Commit 333e423

Browse files
committed
GetMethodParametersTest: add some missing array indexes expectations
This commit: 1. Fixes the order of a few array entries. 2. Adds some array entries which were supposed to be expected, but missing. The use of `assertArraySubset()` hid the fact that these entries were missing. As that assertion now needs to be replaced, these issues came to light.
1 parent bc5d011 commit 333e423

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

tests/Core/File/GetMethodParametersTest.php

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,8 @@ public function testSingleDefaultValue()
9595
$expected[0] = [
9696
'name' => '$var1',
9797
'content' => '$var1=self::CONSTANT',
98-
'has_attributes' => false,
9998
'default' => 'self::CONSTANT',
99+
'has_attributes' => false,
100100
'pass_by_reference' => false,
101101
'variable_length' => false,
102102
'type_hint' => '',
@@ -119,8 +119,8 @@ public function testDefaultValues()
119119
$expected[0] = [
120120
'name' => '$var1',
121121
'content' => '$var1=1',
122-
'has_attributes' => false,
123122
'default' => '1',
123+
'has_attributes' => false,
124124
'pass_by_reference' => false,
125125
'variable_length' => false,
126126
'type_hint' => '',
@@ -129,8 +129,8 @@ public function testDefaultValues()
129129
$expected[1] = [
130130
'name' => '$var2',
131131
'content' => "\$var2='value'",
132-
'has_attributes' => false,
133132
'default' => "'value'",
133+
'has_attributes' => false,
134134
'pass_by_reference' => false,
135135
'variable_length' => false,
136136
'type_hint' => '',
@@ -900,6 +900,7 @@ public function testPHP8ConstructorPropertyPromotionGlobalFunction()
900900
'type_hint' => '',
901901
'nullable_type' => false,
902902
'property_visibility' => 'private',
903+
'property_readonly' => false,
903904
];
904905

905906
$this->getMethodParametersTestHelper('/* '.__FUNCTION__.' */', $expected);
@@ -924,6 +925,7 @@ public function testPHP8ConstructorPropertyPromotionAbstractMethod()
924925
'type_hint' => 'callable',
925926
'nullable_type' => false,
926927
'property_visibility' => 'public',
928+
'property_readonly' => false,
927929
];
928930
$expected[1] = [
929931
'name' => '$x',
@@ -934,6 +936,7 @@ public function testPHP8ConstructorPropertyPromotionAbstractMethod()
934936
'type_hint' => '',
935937
'nullable_type' => false,
936938
'property_visibility' => 'private',
939+
'property_readonly' => false,
937940
];
938941

939942
$this->getMethodParametersTestHelper('/* '.__FUNCTION__.' */', $expected);
@@ -953,6 +956,7 @@ public function testCommentsInParameter()
953956
'name' => '$param',
954957
'content' => '// Leading comment.
955958
?MyClass /*-*/ & /*-*/.../*-*/ $param /*-*/ = /*-*/ \'default value\' . /*-*/ \'second part\' // Trailing comment.',
959+
'default' => '\'default value\' . /*-*/ \'second part\' // Trailing comment.',
956960
'has_attributes' => false,
957961
'pass_by_reference' => true,
958962
'variable_length' => true,
@@ -982,6 +986,7 @@ public function testParameterAttributesInFunctionDeclaration()
982986
'type_hint' => 'string',
983987
'nullable_type' => false,
984988
'property_visibility' => 'private',
989+
'property_readonly' => false,
985990
];
986991
$expected[1] = [
987992
'name' => '$typedParamSingleAttribute',

0 commit comments

Comments
 (0)