Generic/UselessOverridingMethod: consider case-insensitivity of method names

Method names in PHP are case insensitive for ASCII characters.

This commit changes the sniff to compare the name of the declared method with the name
of the called method in a case-insensitive manner for the ASCII characters.
The sniff will now flag methods as useless when PHP would consider the called method
the same as the declared method, even when the called method name is in a different case
as the name used in the function declaration.

Includes unit tests.

Author: rodrigoprimo

src/Standards/Generic/Sniffs/CodeAnalysis/UselessOverridingMethodSniff.php

@@ -97,11 +97,11 @@ public function process(File $phpcsFile, $stackPtr)
             return;
         }
 
-        // Find next non empty token index, should be the function name.
+        // Find next non empty token index, should be the name of the method being called.
         $next = $phpcsFile->findNext(Tokens::$emptyTokens, ($next + 1), null, true);
 
         // Skip for invalid code or other method.
-        if ($next === false || $tokens[$next]['content'] !== $methodName) {
+        if ($next === false || strcasecmp($tokens[$next]['content'], $methodName) !== 0) {
             return;
         }
 

src/Standards/Generic/Tests/CodeAnalysis/UselessOverridingMethodUnitTest.1.inc

@@ -64,6 +64,20 @@ class Bar {
     public function sameNumberDifferentParameters($a, $b) {
         return parent::sameNumberDifferentParameters($this->prop[$a], $this->{$b});
     }
+
+    public function differentCase() {
+        return parent::DIFFERENTcase();
+    }
+
+    public function differentCaseSameNonAnsiiCharáctêrs() {
+        // This should be flagged, only ASCII chars have changed case.
+        return parent::DIFFERENTcaseSameNonAnsiiCharáctêrs();
+    }
+
+    public function differentCaseDifferentNonAnsiiCharáctêrs() {
+        // This should not be flagged as non-ASCII chars have changed case, making this a different method name.
+        return parent::DIFFERENTcaseDifferentNonAnsiiCharÁctÊrs();
+    }
 }
 
 abstract class AbstractFoo {

src/Standards/Generic/Tests/CodeAnalysis/UselessOverridingMethodUnitTest.php

@@ -54,6 +54,8 @@ public function getWarningList($testFile='')
                 16 => 1,
                 38 => 1,
                 56 => 1,
+                68 => 1,
+                72 => 1,
             ];
         default:
             return [];