Skip to content

Commit 3acd7ee

Browse files
authored
Merge pull request #1258 from PHPCSStandards/feature/updates-for-branch-rename
Various updates for branch rename from `master` to `3.x`
2 parents 2432436 + 1433a86 commit 3acd7ee

14 files changed

+30
-31
lines changed

.github/CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ To find bugs which need triage, look for issues and PRs with the
7979
and suggest closing the issue.
8080

8181
Additionally, for older issues:
82-
* Check whether an issue still exists or has been fixed in `master` since the issue was initially reported.
82+
* Check whether an issue still exists or has been fixed since the issue was initially reported.
8383
* If it has been fixed, document (in a comment) which commit/PR was responsible for fixing the issue
8484
and suggest closing the ticket.
8585

@@ -245,7 +245,7 @@ When in doubt how to proceed with a ticket, feel free to leave a comment with sp
245245

246246
1. Fork/clone the repository.
247247
2. Run `composer install`.
248-
3. Create a new branch off the `master` branch to hold your patch.
248+
3. Create a new branch off the `4.x` branch to hold your patch.
249249
If there is an open issue associated with your patch, including the issue number in the branch name is good practice.
250250

251251

.github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ A clear and concise description of what you expected to happen.
5555
|-----------------------------|---------------------------------------------------------------------------- |
5656
| Operating System | (e.g., Windows 10, MacOS 10.15) |
5757
| PHP version | (e.g., 7.2, 8.1) |
58-
| PHP_CodeSniffer version | (e.g., 3.7.2, master) |
58+
| PHP_CodeSniffer version | (e.g., 3.13.4, 4.x) |
5959
| Standard | (e.g., PSR2, PSR12, Squiz, custom) |
6060
| Install type | (e.g. Composer (global/local), PHAR, git clone, other (please expand)) |
6161

@@ -68,4 +68,4 @@ Add any other context about the problem here.
6868
- [ ] I have searched the issue list and am not opening a duplicate issue.
6969
- [ ] I have read the [Contribution Guidelines](https://github.com/PHPCSStandards/PHP_CodeSniffer/blob/HEAD/.github/CONTRIBUTING.md) and this is not a [support question](https://github.com/PHPCSStandards/PHP_CodeSniffer/discussions).
7070
- [ ] I confirm that this bug is a bug in PHP_CodeSniffer and not in one of the external standards.
71-
- [ ] I have verified the issue still exists in the `master` branch of PHP_CodeSniffer.
71+
- [ ] I have verified the issue still exists in the `4.x` branch of PHP_CodeSniffer.

.github/dependabot.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ updates:
1010
directory: "/"
1111
schedule:
1212
interval: "weekly"
13-
target-branch: "master"
13+
target-branch: "3.x"
1414
open-pull-requests-limit: 5
1515
commit-message:
1616
prefix: "GH Actions:"

.github/pull_request_template.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
11
<!-- Provide a general summary of your changes in the title above. -->
22

33
<!--
4-
Please target the `master` branch when submitting your pull request, unless your change **only** applies to PHPCS 4.x.
4+
Please target the branch for the current major when submitting your pull request.
5+
6+
For older majors, only CI, security and PHP runtime compatibility patches will be accepted for up to a year
7+
after the new major was released.
8+
If your patch falls into this category, target the oldest major still accepting patches.
59
-->
610

711
# Description

.github/release-checklist.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ Please consider [funding the PHP_CodeSniffer project](https://opencollective.com
7777

7878
- [ ] Merge the changelog PR.
7979
For now, cherrypick the changelog to the 4.0 branch.
80-
- [ ] Make sure all CI builds for `master` are green.
80+
- [ ] Make sure all CI builds for the release branch are green.
8181
- [ ] Create a tag for the release & push it.
8282
- [ ] Make sure all CI builds are green.
8383
- [ ] Download the PHAR files from the GH Actions test build page.

.github/workflows/build-phar.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
name: Build PHARs
22

33
on:
4-
# Run on pushes to master and on pull requests which touch files used when building the PHARs.
4+
# Run on pushes to the main branches and on pull requests which touch files used when building the PHARs.
55
# Prevent the build from running when there are only irrelevant changes.
66
push:
77
branches:
8-
- master
9-
- 4.0
8+
- 3.x
9+
- 4.x
1010
paths:
1111
- '.github/workflows/build-phar.yml'
1212
- '.github/workflows/reusable-build-phar.yml'

.github/workflows/end-to-end-tests.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
name: E2E Tests
22

33
on:
4-
# Run on pushes to `master`/`4.0` and on all pull requests.
4+
# Run on pushes to the main branches and on all pull requests.
55
# Prevent the build from running when there are only irrelevant changes.
66
push:
77
branches:
8-
- master
9-
- 4.0
8+
- 3.x
9+
- 4.x
1010
tags:
1111
- '**'
1212
paths-ignore:

.github/workflows/happy-new-year.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535
- name: Set branches to use
3636
id: branches
3737
run: |
38-
echo "BASE=master" >> "$GITHUB_OUTPUT"
38+
echo "BASE=3.x" >> "$GITHUB_OUTPUT"
3939
echo "PR_BRANCH=feature/squiz-filecomment-update-copyright-year" >> "$GITHUB_OUTPUT"
4040
4141
# Using "Tomorrow" to prevent accidentally getting last year if the server is not using UTC.

.github/workflows/label-merge-conflicts.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ on:
44
# Check for new conflicts due to merges.
55
push:
66
branches:
7-
- master
8-
- 4.0
7+
- 3.x
8+
- 4.x
99
# Check conflicts in new PRs and for resolved conflicts due to an open PR being updated.
1010
pull_request_target:
1111
types:

.github/workflows/label-new-prs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name: Label new PRs
33
on:
44
# https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target
55
# The `pull_request_target` event is used for "normal" PRs to label them when they are opened.
6-
# This will use the `labeler.yml` file in the default (master) branch of the repo.
6+
# This will use the `labeler.yml` file in the default branch of the repo.
77
pull_request_target:
88
types:
99
- opened

0 commit comments

Comments
 (0)