Squiz/FunctionDeclarationArgumentSpacing: fix fixer conflict / improve SpaceBeforeEquals + SpaceAfterEquals fixers

The fixers for the `SpaceBeforeEquals` and `SpaceAfterEquals` error codes would only handle one whitespace token at a time, which is inefficient.

While this worked correctly when `$equalsSpacing` was set to `0`, as covered by the `newlineBeforeAndAfterEqualsSignShouldBeFixedForSpacing0()` test, it would take four loops instead of two to make the fixes.

However, when `$equalsSpacing` was set to `1` AND there were new lines to deal with, the fixer would get into a fixer conflict with itself as it would keep trying to add a space before the equal sign.
```
        Squiz.Functions.FunctionDeclarationArgumentSpacing:227 replaced token 31 (T_WHITESPACE on line 13) " =" => " ="
```

This commit changes both fixers to handle all whitespace tokens in one go.
This makes the fixers more efficient, but also fixes the fixer conflict which was identified.

Tested via the pre-existing `newlineBeforeAndAfterEqualsSignShouldBeFixedForSpacing0()` test case, as well as the new `newlineBeforeAndAfterEqualsSignShouldBeFixedForSpacing1()` test case.

Author: jrfnl

src/Standards/Squiz/Sniffs/Functions/FunctionDeclarationArgumentSpacingSniff.php

@@ -222,11 +222,15 @@ public function processBracket($phpcsFile, $openBracket)
                         $fix = $phpcsFile->addFixableError($error, $equalToken, 'SpaceBeforeEquals', $data);
                         if ($fix === true) {
                             $padding = str_repeat(' ', $this->equalsSpacing);
-                            if ($spacesBefore === 0) {
-                                $phpcsFile->fixer->addContentBefore($equalToken, $padding);
-                            } else {
-                                $phpcsFile->fixer->replaceToken(($equalToken - 1), $padding);
+
+                            $phpcsFile->fixer->beginChangeset();
+                            $phpcsFile->fixer->addContent($param['token'], $padding);
+
+                            for ($i = ($param['token'] + 1); $tokens[$i]['code'] === T_WHITESPACE; $i++) {
+                                $phpcsFile->fixer->replaceToken($i, '');
                             }
+
+                            $phpcsFile->fixer->endChangeset();
                         }
                     }
                 }//end if
@@ -252,11 +256,15 @@ public function processBracket($phpcsFile, $openBracket)
                         $fix = $phpcsFile->addFixableError($error, $equalToken, 'SpaceAfterEquals', $data);
                         if ($fix === true) {
                             $padding = str_repeat(' ', $this->equalsSpacing);
-                            if ($spacesAfter === 0) {
-                                $phpcsFile->fixer->addContent($equalToken, $padding);
-                            } else {
-                                $phpcsFile->fixer->replaceToken(($equalToken + 1), $padding);
+
+                            $phpcsFile->fixer->beginChangeset();
+                            $phpcsFile->fixer->addContent($equalToken, $padding);
+
+                            for ($i = ($equalToken + 1); $tokens[$i]['code'] === T_WHITESPACE; $i++) {
+                                $phpcsFile->fixer->replaceToken($i, '');
                             }
+
+                            $phpcsFile->fixer->endChangeset();
                         }
                     }
                 }//end if

src/Standards/Squiz/Tests/Functions/FunctionDeclarationArgumentSpacingUnitTest.inc

@@ -166,3 +166,13 @@ function newlineAndCommentBeforeAndAfterEqualsSignShouldBeFlaggedNotFixed(
 
     true
 ) {}
+
+// phpcs:set Squiz.Functions.FunctionDeclarationArgumentSpacing equalsSpacing 1
+function newlineBeforeAndAfterEqualsSignShouldBeFixedForSpacing1(
+    $param
+
+        =
+
+    true
+) {}
+// phpcs:set Squiz.Functions.FunctionDeclarationArgumentSpacing equalsSpacing 0

src/Standards/Squiz/Tests/Functions/FunctionDeclarationArgumentSpacingUnitTest.inc.fixed

@@ -151,3 +151,9 @@ function newlineAndCommentBeforeAndAfterEqualsSignShouldBeFlaggedNotFixed(
 
     true
 ) {}
+
+// phpcs:set Squiz.Functions.FunctionDeclarationArgumentSpacing equalsSpacing 1
+function newlineBeforeAndAfterEqualsSignShouldBeFixedForSpacing1(
+    $param = true
+) {}
+// phpcs:set Squiz.Functions.FunctionDeclarationArgumentSpacing equalsSpacing 0

src/Standards/Squiz/Tests/Functions/FunctionDeclarationArgumentSpacingUnitTest.php

@@ -77,6 +77,7 @@ public function getErrorList()
             149 => 2,
             155 => 2,
             163 => 2,
+            174 => 2,
         ];
 
     }//end getErrorList()