Various sniffs: add extra tests with live coding/parse errors

Includes fixing up some inline comments for sniffs which don't search for closures, but could encounter live coding.

Includes one minor bug fix/defensive coding fix in the `Squiz.Commenting.ClosingDeclarationComment` sniff.

Author: jrfnl

src/Standards/Generic/Tests/CodeAnalysis/UselessOverridingMethodUnitTest.7.inc

@@ -0,0 +1,9 @@
+<?php
+
+// Intentional parse error (missing method name). This should be the only test in the file.
+
+class Bar {
+    function {
+        parent::CallMe();
+    }
+}

src/Standards/Generic/Tests/NamingConventions/ConstructorNameUnitTest.3.inc

@@ -0,0 +1,9 @@
+<?php
+
+// Intentional parse error (missing method name).
+// This should be the only test in this file.
+// Testing that the sniff is *not* triggered.
+
+$anon = class {
+    public function {}
+};

src/Standards/Generic/Tests/NamingConventions/ConstructorNameUnitTest.4.inc

@@ -0,0 +1,11 @@
+<?php
+
+// Intentional parse error (missing method name when gathering list).
+// This should be the only test in this file.
+// Testing that the sniff is *not* triggered.
+
+class LiveCoding {
+    public function __construct() {}
+    public function {}
+    public function myMethod() {}
+}

src/Standards/Generic/Tests/NamingConventions/ConstructorNameUnitTest.5.inc

@@ -0,0 +1,11 @@
+<?php
+
+// Intentional parse error (missing method name when gathering list).
+// This should be the only test in this file.
+// Testing that the sniff is *not* triggered.
+
+$anon = class {
+    public function __construct() {}
+    public function {}
+    public function myMethod() {}
+};

src/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php

@@ -84,7 +84,7 @@ protected function processTokenWithinScope(File $phpcsFile, $stackPtr, $currScop
 
         $methodName = $phpcsFile->getDeclarationName($stackPtr);
         if ($methodName === null) {
-            // Ignore closures.
+            // Ignore live coding.
             return;
         }
 
@@ -182,7 +182,7 @@ protected function processTokenOutsideScope(File $phpcsFile, $stackPtr)
     {
         $functionName = $phpcsFile->getDeclarationName($stackPtr);
         if ($functionName === null) {
-            // Ignore closures.
+            // Ignore live coding.
             return;
         }
 

src/Standards/PEAR/Tests/Commenting/ClassCommentUnitTest.2.inc

@@ -0,0 +1,7 @@
+<?php
+
+// Intentional parse error (missing interface name). This should be the only test in the file.
+
+namespace Vendor\Package;
+
+interface

src/Standards/PEAR/Tests/Commenting/ClassCommentUnitTest.php

@@ -58,6 +58,11 @@ public function getErrorList($testFile='')
                 163 => 1,
             ];
 
+        case 'ClassCommentUnitTest.2.inc':
+            return [
+                7 => 1,
+            ];
+
         default:
             return [];
         }//end switch

src/Standards/PEAR/Tests/Commenting/FunctionCommentUnitTest.2.inc

@@ -0,0 +1,7 @@
+<?php
+
+// Intentional parse error (missing function name). This should be the only test in the file.
+
+namespace Vendor\Package;
+
+function

src/Standards/PEAR/Tests/Commenting/FunctionCommentUnitTest.3.inc

@@ -0,0 +1,14 @@
+<?php
+
+// Intentional parse error (missing method name). This should be the only test in the file.
+
+namespace Vendor\Package;
+
+class LiveCoding {
+    /**
+     * This test needs to hit the processReturn() method.
+     */
+    function {
+        return;
+    }
+}

src/Standards/PEAR/Tests/Commenting/FunctionCommentUnitTest.php

@@ -91,6 +91,16 @@ public function getErrorList($testFile='')
                 545 => 1,
             ];
 
+        case 'FunctionCommentUnitTest.2.inc':
+            return [
+                7 => 1,
+            ];
+
+        case 'FunctionCommentUnitTest.3.inc':
+            return [
+                10 => 1,
+            ];
+
         default:
             return [];
         }//end switch