Merge pull request #1001 from PHPCSStandards/phpcs-4.0/feature/config-setsettings-is-void

jrfnl · web-flow · commit 41d04adb8d21 · 2025-04-15T16:53:31.000+02:00
Config::setSettings(): void method should not return
diff --git a/src/Config.php b/src/Config.php
@@ -374,7 +374,7 @@ public function getSettings()
      */
     public function setSettings($settings)
     {
-        return $this->settings = $settings;
+        $this->settings = $settings;
 
     }//end setSettings()
 

Original file line number	Diff line number	Diff line change
`@@ -374,7 +374,7 @@ public function getSettings()`
`374`	`374`	`*/`
`375`	`375`	`public function setSettings($settings)`
`376`	`376`	`{`
`377`		`- return $this->settings = $settings;`
	`377`	`+ $this->settings = $settings;`
`378`	`378`
`379`	`379`	`}//end setSettings()`
`380`	`380`