Modernize: Generic/UnusedFunctionParameter: use class constant for constant array

Author: jrfnl

src/Standards/Generic/Sniffs/CodeAnalysis/UnusedFunctionParameterSniff.php

@@ -23,22 +23,15 @@
 class UnusedFunctionParameterSniff implements Sniff
 {
 
-    /**
-     * The list of class type hints which will be ignored.
-     *
-     * @var array
-     */
-    public $ignoreTypeHints = [];
-
     /**
      * A list of all PHP magic methods with fixed method signatures.
      *
      * Note: `__construct()` and `__invoke()` are excluded on purpose
      * as their method signature is not fixed.
      *
-     * @var array
+     * @var array<string, true>
      */
-    private $magicMethods = [
+    private const MAGIC_METHODS = [
         '__destruct'    => true,
         '__call'        => true,
         '__callstatic'  => true,
@@ -56,6 +49,13 @@ class UnusedFunctionParameterSniff implements Sniff
         '__debuginfo'   => true,
     ];
 
+    /**
+     * The list of class type hints which will be ignored.
+     *
+     * @var array
+     */
+    public $ignoreTypeHints = [];
+
 
     /**
      * Returns an array of tokens this test wants to listen for.
@@ -101,7 +101,7 @@ public function process(File $phpcsFile, $stackPtr)
                 // Check for magic methods and ignore these as the method signature cannot be changed.
                 $methodName   = $phpcsFile->getDeclarationName($stackPtr);
                 $methodNameLc = strtolower($methodName);
-                if (isset($this->magicMethods[$methodNameLc]) === true) {
+                if (isset(self::MAGIC_METHODS[$methodNameLc]) === true) {
                     return;
                 }