Skip to content

Commit 4b69f88

Browse files
rodrigoprimojrfnl
authored andcommitted
Add links to all issues in the 3.5.1 and 3.5.0 sections of the changelog
This commit also fixes a few typos in the two changelogs.
1 parent f335d41 commit 4b69f88

File tree

1 file changed

+81
-45
lines changed

1 file changed

+81
-45
lines changed

CHANGELOG.md

Lines changed: 81 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -1316,26 +1316,39 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
13161316
- This check has been missing from these standards, but has now been implemented
13171317
- When using the PEAR standard, the error code is PEAR.Functions.FunctionCallSignature.FirstArgumentPosition
13181318
- When using PSR2 or PSR12, the error code is PSR2.Methods.FunctionCallSignature.FirstArgumentPosition
1319-
- PSR12.ControlStructures.BooleanOperatorPlacement no longer complains when multiple expression appears on the same line
1320-
- Previously, boolean operators were enforce to appear at the start or end of lines only
1319+
- PSR12.ControlStructures.BooleanOperatorPlacement no longer complains when multiple expressions appear on the same line
1320+
- Previously, boolean operators were enforced to appear at the start or end of lines only
13211321
- Boolean operators can now appear in the middle of the line
13221322
- PSR12.Files.FileHeader no longer ignores comments preceding a use, namespace, or declare statement
13231323
- PSR12.Files.FileHeader now allows a hashbang line at the top of the file
13241324

13251325
### Fixed
1326-
- Fixed bug #2506 : PSR2 standard can't auto fix multi-line function call inside a string concat statement
1327-
- Fixed bug #2530 : PEAR.Commenting.FunctionComment does not support intersection types in comments
1328-
- Fixed bug #2615 : Constant visibility false positive on non-class constants
1329-
- Fixed bug #2616 : PSR12.Files.FileHeader false positive when file only contains docblock
1330-
- Fixed bug #2619 : PSR12.Files.FileHeader locks up when inline comment is the last content in a file
1331-
- Fixed bug #2621 : PSR12.Classes.AnonClassDeclaration.CloseBraceSameLine false positive for anon class passed as function argument
1326+
- Fixed bug [#2506] : PSR2 standard can't auto fix multi-line function call inside a string concat statement
1327+
- Fixed bug [#2530] : PEAR.Commenting.FunctionComment does not support intersection types in comments
1328+
- Fixed bug [#2615] : Constant visibility false positive on non-class constants
1329+
- Fixed bug [#2616] : PSR12.Files.FileHeader false positive when file only contains docblock
1330+
- Fixed bug [#2619] : PSR12.Files.FileHeader locks up when inline comment is the last content in a file
1331+
- Fixed bug [#2621] : PSR12.Classes.AnonClassDeclaration.CloseBraceSameLine false positive for anon class passed as function argument
13321332
- Thanks to [Martins Sipenko][@martinssipenko] for the patch
1333-
- Fixed bug #2623 : PSR12.ControlStructures.ControlStructureSpacing not ignoring indentation inside multi-line string arguments
1334-
- Fixed bug #2624 : PSR12.Traits.UseDeclaration doesnt apply the correct indent during auto fixing
1335-
- Fixed bug #2626 : PSR12.Files.FileHeader detects @var annotations as file docblocks
1336-
- Fixed bug #2628 : PSR12.Traits.UseDeclaration does not allow comments above a USE declaration
1337-
- Fixed bug #2632 : Incorrect indentation of lines starting with "static" inside closures
1338-
- Fixed bug #2641 : PSR12.Functions.NullableTypeDeclaration false positive when using new static()
1333+
- Fixed bug [#2623] : PSR12.ControlStructures.ControlStructureSpacing not ignoring indentation inside multi-line string arguments
1334+
- Fixed bug [#2624] : PSR12.Traits.UseDeclaration doesnt apply the correct indent during auto fixing
1335+
- Fixed bug [#2626] : PSR12.Files.FileHeader detects @var annotations as file docblocks
1336+
- Fixed bug [#2628] : PSR12.Traits.UseDeclaration does not allow comments above a USE declaration
1337+
- Fixed bug [#2632] : Incorrect indentation of lines starting with "static" inside closures
1338+
- Fixed bug [#2641] : PSR12.Functions.NullableTypeDeclaration false positive when using new static()
1339+
1340+
[#2506]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2506
1341+
[#2530]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2530
1342+
[#2615]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2615
1343+
[#2616]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2616
1344+
[#2619]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2619
1345+
[#2621]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2621
1346+
[#2623]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2623
1347+
[#2624]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2624
1348+
[#2626]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2626
1349+
[#2628]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2628
1350+
[#2632]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2632
1351+
[#2641]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2641
13391352

13401353
## [3.5.0] - 2019-09-27
13411354
### Changed
@@ -1361,11 +1374,11 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
13611374
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
13621375
- The tokenizer now correctly identifies inline control structures in more cases
13631376
- All helper methods inside the File class now throw RuntimeException instead of TokenizerException
1364-
- Some tokenizer methods were also throwing RuntimeExpection but now correctly throw TokenizerException
1377+
- Some tokenizer methods were also throwing RuntimeException but now correctly throw TokenizerException
13651378
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
13661379
- The File::getMethodParameters() method now returns more information, and supports closure USE groups
13671380
- If a type hint is specified, the position of the last token in the hint will be set in a "type_hint_end_token" array index
1368-
- If a default is specified, the position of the first token in the default value will be set in a "default_token" array index
1381+
- If a default is specified, the position of the first token in the default value will be set in a "default_token" array index
13691382
- If a default is specified, the position of the equals sign will be set in a "default_equal_token" array index
13701383
- If the param is not the last, the position of the comma will be set in a "comma_token" array index
13711384
- If the param is passed by reference, the position of the reference operator will be set in a "reference_token" array index
@@ -1425,9 +1438,9 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
14251438
- Use the Squiz.WhiteSpace.OperatorSpacing sniff to enforce spacing around assignment operators
14261439
- Note that this sniff checks spacing around all assignment operators, not just inside function calls
14271440
- The Generic.Functions.FunctionCallArgumentSpacing.NoSpaceBeforeEquals error has been removed
1428-
- use Squiz.WhiteSpace.OperatorSpacing.NoSpaceBefore instead
1441+
- Use Squiz.WhiteSpace.OperatorSpacing.NoSpaceBefore instead
14291442
- The Generic.Functions.FunctionCallArgumentSpacing.NoSpaceAfterEquals error has been removed
1430-
- use Squiz.WhiteSpace.OperatorSpacing.NoSpaceAfter instead
1443+
- Use Squiz.WhiteSpace.OperatorSpacing.NoSpaceAfter instead
14311444
- This also changes the PEAR/PSR2/PSR12 standards so they no longer check assignment operators inside function calls
14321445
- They were previously checking these operators when they should not have
14331446
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
@@ -1455,7 +1468,7 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
14551468
- Squiz.Operators.IncrementDecrementUsage now suggests pre-increment of variables instead of post-increment
14561469
- This change does not enforce pre-increment over post-increment; only the suggestion has changed
14571470
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1458-
- Squiz.PHP.DisallowMultipleAssignments now has a second error code for when assignments are found inside control structure conditions
1471+
- Squiz.PHP.DisallowMultipleAssignments now has a second error code for when assignments are found inside control structure conditions
14591472
- The new error code is Squiz.PHP.DisallowMultipleAssignments.FoundInControlStructure
14601473
- All other multiple assignment cases use the existing error code Squiz.PHP.DisallowMultipleAssignments.Found
14611474
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
@@ -1473,40 +1486,63 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
14731486
- Thanks to [Jakub Chábek][@grongor] for the patch
14741487

14751488
### Fixed
1476-
- Fixed bug #2391 : Sniff-specific ignore rules inside rulesets are filtering out too many files
1489+
- Fixed bug [#2391] : Sniff-specific ignore rules inside rulesets are filtering out too many files
14771490
- Thanks to [Juliette Reinders Folmer][@jrfnl] and [Willington Vega][@wvega] for the patch
1478-
- Fixed bug #2478 : FunctionCommentThrowTag.WrongNumber when exception is thrown once but built conditionally
1479-
- Fixed bug #2479 : Generic.WhiteSpace.ScopeIndent error when using array destructing with exact indent checking
1480-
- Fixed bug #2498 : Squiz.Arrays.ArrayDeclaration.MultiLineNotAllowed autofix breaks heredoc
1481-
- Fixed bug #2502 : Generic.WhiteSpace.ScopeIndent false positives with nested switch indentation and case fall-through
1482-
- Fixed bug #2504 : Generic.WhiteSpace.ScopeIndent false positives with nested arrays and nowdoc string
1483-
- Fixed bug #2511 : PSR2 standard not checking if closing paren of single-line function declaration is on new line
1484-
- Fixed bug #2512 : Squiz.PHP.NonExecutableCode does not support alternate SWITCH control structure
1491+
- Fixed bug [#2478] : FunctionCommentThrowTag.WrongNumber when exception is thrown once but built conditionally
1492+
- Fixed bug [#2479] : Generic.WhiteSpace.ScopeIndent error when using array destructing with exact indent checking
1493+
- Fixed bug [#2498] : Squiz.Arrays.ArrayDeclaration.MultiLineNotAllowed autofix breaks heredoc
1494+
- Fixed bug [#2502] : Generic.WhiteSpace.ScopeIndent false positives with nested switch indentation and case fall-through
1495+
- Fixed bug [#2504] : Generic.WhiteSpace.ScopeIndent false positives with nested arrays and nowdoc string
1496+
- Fixed bug [#2511] : PSR2 standard not checking if closing paren of single-line function declaration is on new line
1497+
- Fixed bug [#2512] : Squiz.PHP.NonExecutableCode does not support alternate SWITCH control structure
14851498
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1486-
- Fixed bug #2522 : Text generator throws error when code sample line is too long
1499+
- Fixed bug [#2522] : Text generator throws error when code sample line is too long
14871500
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1488-
- Fixed bug #2526 : XML report format has bad syntax on Windows
1501+
- Fixed bug [#2526] : XML report format has bad syntax on Windows
14891502
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1490-
- Fixed bug #2529 : Generic.Formatting.MultipleStatementAlignment wrong error for assign in string concat
1491-
- Fixed bug #2534 : Unresolvable installed_paths can lead to open_basedir errors
1503+
- Fixed bug [#2529] : Generic.Formatting.MultipleStatementAlignment wrong error for assign in string concat
1504+
- Fixed bug [#2534] : Unresolvable installed_paths can lead to open_basedir errors
14921505
- Thanks to [Oliver Nowak][@ndm2] for the patch
1493-
- Fixed bug #2541 : Text doc generator does not allow for multi-line rule explanations
1506+
- Fixed bug [#2541] : Text doc generator does not allow for multi-line rule explanations
14941507
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1495-
- Fixed bug #2549 : Searching for a phpcs.xml file can throw warnings due to open_basedir restrictions
1508+
- Fixed bug [#2549] : Searching for a phpcs.xml file can throw warnings due to open_basedir restrictions
14961509
- Thanks to [Matthew Peveler][@MasterOdin] for the patch
1497-
- Fixed bug #2558 : PHP 7.4 throwing offset syntax with curly braces is deprecated message
1510+
- Fixed bug [#2558] : PHP 7.4 throwing offset syntax with curly braces is deprecated message
14981511
- Thanks to [Matthew Peveler][@MasterOdin] for the patch
1499-
- Fixed bug #2561 : PHP 7.4 compatibility fix / implode argument order
1500-
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1501-
- Fixed bug #2562 : Inline WHILE triggers SpaceBeforeSemicolon incorrectly
1502-
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1503-
- Fixed bug #2565 : Generic.ControlStructures.InlineControlStructure confused by mixed short/long tags
1504-
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1505-
- Fixed bug #2566 : Author tag email validation doesn't support all TLDs
1506-
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1507-
- Fixed bug #2575 : Custom error messages don't have data replaced when cache is enabled
1508-
- Fixed bug #2601 : Squiz.WhiteSpace.FunctionSpacing incorrect fix when spacing is 0
1509-
- Fixed bug #2608 : PSR2 throws errors for use statements when multiple namespaces are defined in a file
1512+
- Fixed bug [#2561] : PHP 7.4 compatibility fix / implode argument order
1513+
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1514+
- Fixed bug [#2562] : Inline WHILE triggers SpaceBeforeSemicolon incorrectly
1515+
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1516+
- Fixed bug [#2565] : Generic.ControlStructures.InlineControlStructure confused by mixed short/long tags
1517+
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1518+
- Fixed bug [#2566] : Author tag email validation doesn't support all TLDs
1519+
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1520+
- Fixed bug [#2575] : Custom error messages don't have data replaced when cache is enabled
1521+
- Fixed bug [#2601] : Squiz.WhiteSpace.FunctionSpacing incorrect fix when spacing is 0
1522+
- Fixed bug [#2608] : PSR2 throws errors for use statements when multiple namespaces are defined in a file
1523+
1524+
[#2391]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2391
1525+
[#2478]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2478
1526+
[#2479]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2479
1527+
[#2498]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2498
1528+
[#2502]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2502
1529+
[#2504]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2504
1530+
[#2511]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2511
1531+
[#2512]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2512
1532+
[#2522]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2522
1533+
[#2526]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2526
1534+
[#2529]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2529
1535+
[#2534]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2534
1536+
[#2541]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2541
1537+
[#2549]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2549
1538+
[#2558]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2558
1539+
[#2561]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2561
1540+
[#2562]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2562
1541+
[#2565]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2565
1542+
[#2566]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2566
1543+
[#2575]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2575
1544+
[#2601]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2601
1545+
[#2608]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2608
15101546

15111547
## [3.4.2] - 2019-04-11
15121548
### Changed

0 commit comments

Comments
 (0)