Skip to content

Commit 526532d

Browse files
rodrigoprimojrfnl
authored andcommitted
Add links to all issues in the 3.5.3 and 3.5.2 sections of the changelog
This commit also fixes a few typos in the two changelogs.
1 parent e9d86e0 commit 526532d

File tree

1 file changed

+35
-18
lines changed

1 file changed

+35
-18
lines changed

CHANGELOG.md

Lines changed: 35 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1219,7 +1219,7 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
12191219
- The double arrow becomes the scope opener, and uses a new T_FN_ARROW token type
12201220
- The token after the statement (normally a semicolon) becomes the scope closer
12211221
- The token is also associated with the opening and closing parenthesis of the statement
1222-
- Any functions named "fn" will cause have a T_FN token for the function name, but have no scope information
1222+
- Any functions named "fn" will have a T_FN token for the function name, but have no scope information
12231223
- Thanks to [Michał Bundyra][@michalbundyra] for the help with this change
12241224
- PHP 7.4 numeric separators are now tokenized in the same way when using older PHP versions
12251225
- Previously, a number like 1_000 would tokenize as T_LNUMBER (1), T_STRING (_000)
@@ -1255,24 +1255,34 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
12551255
- Thanks to [Michał Bundyra][@michalbundyra] for the patch
12561256

12571257
### Fixed
1258-
- Fixed bug #2586 : Generic.WhiteSpace.ScopeIndent false positives when indenting open tags at a non tab-stop
1259-
- Fixed bug #2638 : Squiz.CSS.DuplicateClassDefinitionSniff sees comments as part of the class name
1258+
- Fixed bug [#2586] : Generic.WhiteSpace.ScopeIndent false positives when indenting open tags at a non tab-stop
1259+
- Fixed bug [#2638] : Squiz.CSS.DuplicateClassDefinitionSniff sees comments as part of the class name
12601260
- Thanks to [Raphael Horber][@rhorber] for the patch
1261-
- Fixed bug #2640 : Squiz.WhiteSpace.OperatorSpacing false positives for some negation operators
1261+
- Fixed bug [#2640] : Squiz.WhiteSpace.OperatorSpacing false positives for some negation operators
12621262
- Thanks to [Jakub Chábek][@grongor] and [Juliette Reinders Folmer][@jrfnl] for the patch
1263-
- Fixed bug #2674 : Squiz.Functions.FunctionDeclarationArgumentSpacing prints wrong argument name in error message
1264-
- Fixed bug #2676 : PSR12.Files.FileHeader locks up when file ends with multiple inline comments
1265-
- Fixed bug #2678 : PSR12.Classes.AnonClassDeclaration incorrectly enforcing that closing brace be on a line by itself
1266-
- Fixed bug #2685 : File::getMethodParameters() setting typeHintEndToken for vars with no type hint
1263+
- Fixed bug [#2674] : Squiz.Functions.FunctionDeclarationArgumentSpacing prints wrong argument name in error message
1264+
- Fixed bug [#2676] : PSR12.Files.FileHeader locks up when file ends with multiple inline comments
1265+
- Fixed bug [#2678] : PSR12.Classes.AnonClassDeclaration incorrectly enforcing that closing brace be on a line by itself
1266+
- Fixed bug [#2685] : File::getMethodParameters() setting typeHintEndToken for vars with no type hint
12671267
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1268-
- Fixed bug #2694 : AbstractArraySniff produces invalid indices when using ternary operator
1268+
- Fixed bug [#2694] : AbstractArraySniff produces invalid indices when using ternary operator
12691269
- Thanks to [Michał Bundyra][@michalbundyra] for the patch
1270-
- Fixed bug #2702 : Generic.WhiteSpace.ScopeIndent false positive when using ternary operator with short arrays
1270+
- Fixed bug [#2702] : Generic.WhiteSpace.ScopeIndent false positive when using ternary operator with short arrays
1271+
1272+
[#2586]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2586
1273+
[#2638]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2638
1274+
[#2640]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2640
1275+
[#2674]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2674
1276+
[#2676]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2676
1277+
[#2678]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2678
1278+
[#2685]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2685
1279+
[#2694]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2694
1280+
[#2702]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2702
12711281

12721282
## [3.5.2] - 2019-10-28
12731283
### Changed
12741284
- Generic.ControlStructures.DisallowYodaConditions now returns less false positives
1275-
- False positives were being returned for array comparisions, or when performing some function calls
1285+
- False positives were being returned for array comparisons, or when performing some function calls
12761286
- Squiz.WhiteSpace.SemicolonSpacing.Incorrect error message now escapes newlines and tabs
12771287
- Provides a clearer error message as whitespace is now visible
12781288
- Also allows for better output for report types such as CSV and XML
@@ -1281,13 +1291,20 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
12811291
- Thanks to [Craig Duncan][@duncan3dc] for the patch
12821292

12831293
### Fixed
1284-
- Fixed bug #2654 : Incorrect indentation for arguments of multiline function calls
1285-
- Fixed bug #2656 : Squiz.WhiteSpace.MemberVarSpacing removes comments before first member var during auto fixing
1286-
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1287-
- Fixed bug #2663 : Generic.NamingConventions.ConstructorName complains about old constructor in interfaces
1288-
- Fixed bug #2664 : PSR12.Files.OpenTag incorrectly identifies PHP file with only an opening tag
1289-
- Fixed bug #2665 : PSR12.Files.ImportStatement should not apply to traits
1290-
- Fixed bug #2673 : PSR12.Traits.UseDeclaration does not allow comments or blank lines between use statements
1294+
- Fixed bug [#2654] : Incorrect indentation for arguments of multiline function calls
1295+
- Fixed bug [#2656] : Squiz.WhiteSpace.MemberVarSpacing removes comments before first member var during auto fixing
1296+
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1297+
- Fixed bug [#2663] : Generic.NamingConventions.ConstructorName complains about old constructor in interfaces
1298+
- Fixed bug [#2664] : PSR12.Files.OpenTag incorrectly identifies PHP file with only an opening tag
1299+
- Fixed bug [#2665] : PSR12.Files.ImportStatement should not apply to traits
1300+
- Fixed bug [#2673] : PSR12.Traits.UseDeclaration does not allow comments or blank lines between use statements
1301+
1302+
[#2654]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2654
1303+
[#2656]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2656
1304+
[#2663]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2663
1305+
[#2664]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2664
1306+
[#2665]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2665
1307+
[#2673]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2673
12911308

12921309
## [3.5.1] - 2019-10-17
12931310
### Changed

0 commit comments

Comments
 (0)