Modernize: use PHP_OS_FAMILY constant (follow-up)

jrfnl · jrfnl · commit 5d76334cfc13 · 2025-06-04T18:41:43.000+02:00
Follow up on PR 1035, this commit simplifies one more "is this Windows ?" check.
diff --git a/src/Util/Common.php b/src/Util/Common.php
@@ -218,7 +218,7 @@ public static function isStdinATTY()
         }
 
         // Next try is detecting whether we have `tty` installed and use that.
-        if (defined('PHP_WINDOWS_VERSION_PLATFORM') === true) {
+        if (PHP_OS_FAMILY === 'Windows') {
             $devnull = 'NUL';
             $which   = 'where';
         } else {

Original file line number	Diff line number	Diff line change
`@@ -218,7 +218,7 @@ public static function isStdinATTY()`
`218`	`218`	`}`
`219`	`219`
`220`	`220`	// Next try is detecting whether we have `tty` installed and use that.
`221`		`- if (defined('PHP_WINDOWS_VERSION_PLATFORM') === true) {`
	`221`	`+ if (PHP_OS_FAMILY === 'Windows') {`
`222`	`222`	`$devnull = 'NUL';`
`223`	`223`	`$which = 'where';`
`224`	`224`	`} else {`