Ruleset/PropertyTypeHandlingTest: add tests with extended arrays

Add some extra tests to verify that extending a (new style) array property declaration works as expected.

While this is also tested via the `ProcessRuleShouldProcessElementTest`, some extra tests seemed warranted.

Author: jrfnl

tests/Core/Ruleset/Fixtures/PropertyTypeHandlingInline.inc

@@ -19,8 +19,12 @@
 
 // phpcs:set TestStandard.SetProperty.PropertyTypeHandling expectsArrayWithOnlyValues[] string, 10, 1.5, null, true, false
 // phpcs:set TestStandard.SetProperty.PropertyTypeHandling expectsArrayWithKeysAndValues[] string=>string,10=>10,float=>1.5,null=>null,true=>true,false=>false
+// phpcs:set TestStandard.SetProperty.PropertyTypeHandling expectsArrayWithExtendedValues[] string, 15, another string
+// phpcs:set TestStandard.SetProperty.PropertyTypeHandling expectsArrayWithExtendedKeysAndValues[] 10=>10,string=>string,15=>15,another string=>another string
 
 // phpcs:set TestStandard.SetProperty.PropertyTypeHandling expectsOldSchoolArrayWithOnlyValues[] string, 10, 1.5, null, true, false
 // phpcs:set TestStandard.SetProperty.PropertyTypeHandling expectsOldSchoolArrayWithKeysAndValues[] string=>string,10=>10,float=>1.5,null=>null,true=>true,false=>false
+// phpcs:set TestStandard.SetProperty.PropertyTypeHandling expectsOldSchoolArrayWithExtendedValues[] string, 15, another string
+// phpcs:set TestStandard.SetProperty.PropertyTypeHandling expectsOldSchoolArrayWithExtendedKeysAndValues[] 10=>10,string=>string,15=>15,another string=>another string
 
 echo 'hello!';

tests/Core/Ruleset/Fixtures/TestStandard/Sniffs/SetProperty/PropertyTypeHandlingSniff.php

@@ -99,6 +99,20 @@ final class PropertyTypeHandlingSniff implements Sniff
      */
     public $expectsArrayWithKeysAndValues;
 
+    /**
+     * Used to verify that array properties can get extended.
+     *
+     * @var array<mixed>
+     */
+    public $expectsArrayWithExtendedValues;
+
+    /**
+     * Used to verify that array properties can get extended.
+     *
+     * @var array<mixed>
+     */
+    public $expectsArrayWithExtendedKeysAndValues;
+
     /**
      * Used to verify that array properties passed as a string get parsed to a proper array.
      *
@@ -113,6 +127,20 @@ final class PropertyTypeHandlingSniff implements Sniff
      */
     public $expectsOldSchoolArrayWithKeysAndValues;
 
+    /**
+     * Used to verify that array properties passed as a string can get extended.
+     *
+     * @var array<string, mixed>
+     */
+    public $expectsOldSchoolArrayWithExtendedValues;
+
+    /**
+     * Used to verify that array properties passed as a string can get extended.
+     *
+     * @var array<string, mixed>
+     */
+    public $expectsOldSchoolArrayWithExtendedKeysAndValues;
+
     public function register()
     {
         return [T_ECHO];

tests/Core/Ruleset/PropertyTypeHandlingTest.php

@@ -102,6 +102,18 @@ public static function dataTypeHandling()
             'false'  => 'false',
         ];
 
+        $expectedArrayOnlyValuesExtended    = [
+            'string',
+            '15',
+            'another string',
+        ];
+        $expectedArrayKeysAndValuesExtended = [
+            10               => '10',
+            'string'         => 'string',
+            15               => '15',
+            'another string' => 'another string',
+        ];
+
         return [
             'String value (default)'                         => [
                 'propertyName' => 'expectsString',
@@ -151,6 +163,15 @@ public static function dataTypeHandling()
                 'propertyName' => 'expectsArrayWithKeysAndValues',
                 'expected'     => $expectedArrayKeysAndValues,
             ],
+            'Array with only values extended'                => [
+                'propertyName' => 'expectsArrayWithExtendedValues',
+                'expected'     => $expectedArrayOnlyValuesExtended,
+            ],
+            'Array with keys and values extended'            => [
+                'propertyName' => 'expectsArrayWithExtendedKeysAndValues',
+                'expected'     => $expectedArrayKeysAndValuesExtended,
+            ],
+
         ];
 
     }//end dataTypeHandling()

tests/Core/Ruleset/PropertyTypeHandlingTest.xml

@@ -34,6 +34,25 @@
                 <element key="true" value="true"/>
                 <element key="false" value="false"/>
             </property>
+
+            <property name="expectsArrayWithExtendedValues" type="array">
+                <element value="string"/>
+            </property>
+
+            <property name="expectsArrayWithExtendedValues" type="array" extend="true">
+                <element value="15"/>
+                <element value="another string"/>
+            </property>
+
+            <property name="expectsArrayWithExtendedKeysAndValues" type="array">
+                <element key="10" value="10"/>
+                <element key="string" value="string"/>
+            </property>
+
+            <property name="expectsArrayWithExtendedKeysAndValues" type="array" extend="true">
+                <element key="15" value="15"/>
+                <element key="another string" value="another string"/>
+            </property>
         </properties>
     </rule>