Generic/DuplicateClassName: bug fix - namespace is reset on PHP open tag

As things were, the sniff listens to the `T_OPEN_TAG` token, processes the file until the first `T_CLOSE_TAG` and then waits again for a new `T_OPEN_TAG`.

However, every time the sniff is called, the namespace is reset, even when still processing the same file, i.e. when the namespace is still in effect.

This led to both false positives as well as false negatives.

Fixed now, by always processing the complete file in one go and not returning on a `T_CLOSE_TAG`.

Includes unit tests.

Author: jrfnl

src/Standards/Generic/Sniffs/Classes/DuplicateClassNameSniff.php

@@ -56,17 +56,10 @@ public function process(File $phpcsFile, $stackPtr)
             T_TRAIT,
             T_ENUM,
             T_NAMESPACE,
-            T_CLOSE_TAG,
         ];
 
         $stackPtr = $phpcsFile->findNext($findTokens, ($stackPtr + 1));
         while ($stackPtr !== false) {
-            if ($tokens[$stackPtr]['code'] === T_CLOSE_TAG) {
-                // We can stop here. The sniff will continue from the next open
-                // tag when PHPCS reaches that token, if there is one.
-                return;
-            }
-
             // Keep track of what namespace we are in.
             if ($tokens[$stackPtr]['code'] === T_NAMESPACE) {
                 $nextNonEmpty = $phpcsFile->findNext(Tokens::$emptyTokens, ($stackPtr + 1), null, true);
@@ -121,6 +114,8 @@ public function process(File $phpcsFile, $stackPtr)
             $stackPtr = $phpcsFile->findNext($findTokens, ($stackPtr + 1));
         }//end while
 
+        return $phpcsFile->numTokens;
+
     }//end process()
 
 

src/Standards/Generic/Tests/Classes/DuplicateClassNameUnitTest.10.inc

@@ -0,0 +1,6 @@
+<?php
+namespace Code\IsNamespaced ?>
+
+<?php
+class MyClass {}
+interface MyInterface {}

src/Standards/Generic/Tests/Classes/DuplicateClassNameUnitTest.11.inc

@@ -0,0 +1,13 @@
+<?php
+namespace Code\IsNamespaced;
+class FooBar {}
+
+namespace Code\AnotherNamespace;
+
+namespace Code\IsNamespaced ?>
+
+<?php
+echo '123';
+?>
+<?php
+class FooBar {}

src/Standards/Generic/Tests/Classes/DuplicateClassNameUnitTest.php

@@ -85,6 +85,9 @@ public function getWarningList($testFile='')
                 4 => 1,
             ];
 
+        case 'DuplicateClassNameUnitTest.11.inc':
+            return [13 => 1];
+
         default:
             return [];
         }//end switch