Improved the error message when Squiz.ControlStructures.ControlSignature detects a newline after the closing parenthesis

Author: gsherwood

package.xml

@@ -36,6 +36,7 @@ http://pear.php.net/dtd/package-2.0.xsd">
   - NOWDOC tokens are now considered conditions, just as HEREDOC tokens are
     -- This makes it easier to find the start and end of a NOWDOC from any token within it
     -- Thanks to Michał Bundyra for the patch
+  - Improved the error message when Squiz.ControlStructures.ControlSignature detects a newline after the closing parenthesis
   - Fixed bug #1465 : Generic.WhiteSpace.ScopeIndent reports incorrect errors when indenting double arrows in short arrays
   - Fixed bug #1478 : Indentation in fallthrough CASE that contains a closure
   - Fixed bug #1497 : Fatal error if composer prepend-autoloader is set to false

src/Standards/Squiz/Sniffs/ControlStructures/ControlSignatureSniff.php

@@ -106,7 +106,9 @@ public function process(File $phpcsFile, $stackPtr)
 
             if ($content !== ' ') {
                 $error = 'Expected 1 space after closing parenthesis; found %s';
-                if (trim($content) === '') {
+                if ($tokens[$closer]['line'] !== $tokens[$opener]['line']) {
+                    $found = 'newline';
+                } else if (trim($content) === '') {
                     $found = strlen($content);
                 } else {
                     $found = '"'.str_replace($phpcsFile->eolChar, '\n', $content).'"';