Skip to content

Commit 746ce57

Browse files
authored
Merge pull request #492 from PHPCSStandards/feature/tests-tokenizer-reorganize
Feature/tests tokenizer reorganize
2 parents 792a2cf + 5ed168c commit 746ce57

File tree

71 files changed

+1638
-121
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

71 files changed

+1638
-121
lines changed

phpcs.xml.dist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@
139139

140140
<!-- This test file specifically *needs* Windows line endings for testing purposes. -->
141141
<rule ref="Generic.Files.LineEndings.InvalidEOLChar">
142-
<exclude-pattern>tests/Core/Tokenizer/StableCommentWhitespaceWinTest\.php</exclude-pattern>
142+
<exclude-pattern>tests/Core/Tokenizer/PHP/StableCommentWhitespaceWinTest\.php</exclude-pattern>
143143
</rule>
144144

145145
<!-- Avoid false positive with this sniff detecting itself -->

tests/Core/Tokenizer/AnonClassParenthesisOwnerTest.php renamed to tests/Core/Tokenizer/PHP/AnonClassParenthesisOwnerTest.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@
77
* @license https://github.com/PHPCSStandards/PHP_CodeSniffer/blob/master/licence.txt BSD Licence
88
*/
99

10-
namespace PHP_CodeSniffer\Tests\Core\Tokenizer;
10+
namespace PHP_CodeSniffer\Tests\Core\Tokenizer\PHP;
11+
12+
use PHP_CodeSniffer\Tests\Core\Tokenizer\AbstractTokenizerTestCase;
1113

1214
final class AnonClassParenthesisOwnerTest extends AbstractTokenizerTestCase
1315
{

tests/Core/Tokenizer/ArrayKeywordTest.php renamed to tests/Core/Tokenizer/PHP/ArrayKeywordTest.php

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@
77
* @license https://github.com/PHPCSStandards/PHP_CodeSniffer/blob/master/licence.txt BSD Licence
88
*/
99

10-
namespace PHP_CodeSniffer\Tests\Core\Tokenizer;
10+
namespace PHP_CodeSniffer\Tests\Core\Tokenizer\PHP;
11+
12+
use PHP_CodeSniffer\Tests\Core\Tokenizer\AbstractTokenizerTestCase;
1113

1214
final class ArrayKeywordTest extends AbstractTokenizerTestCase
1315
{
@@ -21,7 +23,6 @@ final class ArrayKeywordTest extends AbstractTokenizerTestCase
2123
*
2224
* @dataProvider dataArrayKeyword
2325
* @covers PHP_CodeSniffer\Tokenizers\PHP::tokenize
24-
* @covers PHP_CodeSniffer\Tokenizers\Tokenizer::createTokenMap
2526
*
2627
* @return void
2728
*/
@@ -35,10 +36,6 @@ public function testArrayKeyword($testMarker, $testContent='array')
3536
$this->assertSame(T_ARRAY, $tokenArray['code'], 'Token tokenized as '.$tokenArray['type'].', not T_ARRAY (code)');
3637
$this->assertSame('T_ARRAY', $tokenArray['type'], 'Token tokenized as '.$tokenArray['type'].', not T_ARRAY (type)');
3738

38-
$this->assertArrayHasKey('parenthesis_owner', $tokenArray, 'Parenthesis owner is not set');
39-
$this->assertArrayHasKey('parenthesis_opener', $tokenArray, 'Parenthesis opener is not set');
40-
$this->assertArrayHasKey('parenthesis_closer', $tokenArray, 'Parenthesis closer is not set');
41-
4239
}//end testArrayKeyword()
4340

4441

@@ -84,7 +81,6 @@ public static function dataArrayKeyword()
8481
*
8582
* @dataProvider dataArrayType
8683
* @covers PHP_CodeSniffer\Tokenizers\PHP::tokenize
87-
* @covers PHP_CodeSniffer\Tokenizers\Tokenizer::createTokenMap
8884
*
8985
* @return void
9086
*/
@@ -98,10 +94,6 @@ public function testArrayType($testMarker, $testContent='array')
9894
$this->assertSame(T_STRING, $tokenArray['code'], 'Token tokenized as '.$tokenArray['type'].', not T_STRING (code)');
9995
$this->assertSame('T_STRING', $tokenArray['type'], 'Token tokenized as '.$tokenArray['type'].', not T_STRING (type)');
10096

101-
$this->assertArrayNotHasKey('parenthesis_owner', $tokenArray, 'Parenthesis owner is set');
102-
$this->assertArrayNotHasKey('parenthesis_opener', $tokenArray, 'Parenthesis opener is set');
103-
$this->assertArrayNotHasKey('parenthesis_closer', $tokenArray, 'Parenthesis closer is set');
104-
10597
}//end testArrayType()
10698

10799

@@ -163,7 +155,6 @@ public static function dataArrayType()
163155
*
164156
* @dataProvider dataNotArrayKeyword
165157
* @covers PHP_CodeSniffer\Tokenizers\PHP::tokenize
166-
* @covers PHP_CodeSniffer\Tokenizers\Tokenizer::createTokenMap
167158
*
168159
* @return void
169160
*/
@@ -177,10 +168,6 @@ public function testNotArrayKeyword($testMarker, $testContent='array')
177168
$this->assertSame(T_STRING, $tokenArray['code'], 'Token tokenized as '.$tokenArray['type'].', not T_STRING (code)');
178169
$this->assertSame('T_STRING', $tokenArray['type'], 'Token tokenized as '.$tokenArray['type'].', not T_STRING (type)');
179170

180-
$this->assertArrayNotHasKey('parenthesis_owner', $tokenArray, 'Parenthesis owner is set');
181-
$this->assertArrayNotHasKey('parenthesis_opener', $tokenArray, 'Parenthesis opener is set');
182-
$this->assertArrayNotHasKey('parenthesis_closer', $tokenArray, 'Parenthesis closer is set');
183-
184171
}//end testNotArrayKeyword()
185172

186173

tests/Core/Tokenizer/AttributesTest.php renamed to tests/Core/Tokenizer/PHP/AttributesTest.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@
77
* @license https://github.com/PHPCSStandards/PHP_CodeSniffer/blob/master/licence.txt BSD Licence
88
*/
99

10-
namespace PHP_CodeSniffer\Tests\Core\Tokenizer;
10+
namespace PHP_CodeSniffer\Tests\Core\Tokenizer\PHP;
11+
12+
use PHP_CodeSniffer\Tests\Core\Tokenizer\AbstractTokenizerTestCase;
1113

1214
final class AttributesTest extends AbstractTokenizerTestCase
1315
{

tests/Core/Tokenizer/BackfillEnumTest.php renamed to tests/Core/Tokenizer/PHP/BackfillEnumTest.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@
77
* @license https://github.com/PHPCSStandards/PHP_CodeSniffer/blob/master/licence.txt BSD Licence
88
*/
99

10-
namespace PHP_CodeSniffer\Tests\Core\Tokenizer;
10+
namespace PHP_CodeSniffer\Tests\Core\Tokenizer\PHP;
11+
12+
use PHP_CodeSniffer\Tests\Core\Tokenizer\AbstractTokenizerTestCase;
1113

1214
final class BackfillEnumTest extends AbstractTokenizerTestCase
1315
{

0 commit comments

Comments
 (0)