CS: don't use double quotes where not needed

Co-authored-by: jrfnl <[email protected]>

Author: gsherwood

phpcs.xml.dist

@@ -58,6 +58,7 @@
     <rule ref="Squiz.PHP.DisallowInlineIf"/>
     <rule ref="Squiz.Scope.MethodScope"/>
     <rule ref="Squiz.Strings.ConcatenationSpacing"/>
+    <rule ref="Squiz.Strings.DoubleQuoteUsage.NotRequired"/>
     <rule ref="Squiz.WhiteSpace.ControlStructureSpacing"/>
     <rule ref="Squiz.WhiteSpace.FunctionClosingBraceSpace"/>
     <rule ref="Squiz.WhiteSpace.FunctionSpacing"/>

src/Config.php

@@ -1592,7 +1592,7 @@ public static function getExecutablePath(string $name)
             return $data;
         }
 
-        if ($name === "php") {
+        if ($name === 'php') {
             // For php, we know the executable path. There's no need to look it up.
             return PHP_BINARY;
         }

src/Reports/Json.php

@@ -57,7 +57,7 @@ public function generateFileReport(array $report, File $phpcsFile, bool $showSou
                     $messagesObject->column  = $column;
                     $messagesObject->fixable = $fixable;
 
-                    $messages .= json_encode($messagesObject).",";
+                    $messages .= json_encode($messagesObject).',';
                 }
             }
         }//end foreach
@@ -99,7 +99,7 @@ public function generate(
     ) {
         echo '{"totals":{"errors":'.$totalErrors.',"warnings":'.$totalWarnings.',"fixable":'.$totalFixable.'},"files":{';
         echo rtrim($cachedData, ',');
-        echo "}}".PHP_EOL;
+        echo '}}'.PHP_EOL;
 
     }//end generate()
 

tests/Core/Ruleset/ExplainTest.php

@@ -179,7 +179,7 @@ public function testExplainCustomRuleset()
     public function testExplainWithDeprecatedSniffs()
     {
         // Set up the ruleset.
-        $standard = __DIR__."/ShowSniffDeprecationsTest.xml";
+        $standard = __DIR__.'/ShowSniffDeprecationsTest.xml';
         $config   = new ConfigDouble(["--standard=$standard", '-e']);
         $ruleset  = new Ruleset($config);
 

tests/Core/Ruleset/GetIgnorePatternsTest.php

@@ -37,7 +37,7 @@ final class GetIgnorePatternsTest extends TestCase
     public static function setUpBeforeClass(): void
     {
         // Set up the ruleset.
-        $standard      = __DIR__."/GetIgnorePatternsTest.xml";
+        $standard      = __DIR__.'/GetIgnorePatternsTest.xml';
         $config        = new ConfigDouble(["--standard=$standard"]);
         self::$ruleset = new Ruleset($config);
 

tests/Core/Ruleset/GetIncludePatternsTest.php

@@ -37,7 +37,7 @@ final class GetIncludePatternsTest extends TestCase
     public static function setUpBeforeClass(): void
     {
         // Set up the ruleset.
-        $standard      = __DIR__."/GetIncludePatternsTest.xml";
+        $standard      = __DIR__.'/GetIncludePatternsTest.xml';
         $config        = new ConfigDouble(["--standard=$standard"]);
         self::$ruleset = new Ruleset($config);
 

tests/Core/Tokenizers/PHP/AttributesTest.php

@@ -540,7 +540,7 @@ public static function dataAttributeOnTextLookingLikeCloseTag()
                     ],
                     [
                         'T_WHITESPACE',
-                        "    ",
+                        '    ',
                     ],
                     [
                         'T_CONSTANT_ENCAPSED_STRING',

tests/Core/Util/Common/PrepareForOutputTest.php

@@ -79,16 +79,16 @@ public static function dataPrepareForOutput()
                 'expectedWin' => "\\r\\n\\t",
             ],
             'Spaces are replaced with a unique mark'             => [
-                'content'     => "    ",
+                'content'     => '    ',
                 'exclude'     => [],
                 'expected'    => "\033[30;1m·\033[0m\033[30;1m·\033[0m\033[30;1m·\033[0m\033[30;1m·\033[0m",
-                'expectedWin' => "    ",
+                'expectedWin' => '    ',
             ],
             'Other characters are unaffected'                    => [
-                'content'     => "{echo 1;}",
+                'content'     => '{echo 1;}',
                 'exclude'     => [],
                 'expected'    => "{echo\033[30;1m·\033[0m1;}",
-                'expectedWin' => "{echo 1;}",
+                'expectedWin' => '{echo 1;}',
             ],
             'No replacements'                                    => [
                 'content'     => 'nothing-should-be-replaced',