Generators/HTML::getFormattedHeader(): minor simplification

jrfnl · jrfnl · commit 84d0a5f6960d · 2025-02-16T01:04:48.000+01:00
Use a single call to `sprintf()` instead of lots of string concatenation.
diff --git a/src/Generators/HTML.php b/src/Generators/HTML.php
@@ -149,15 +149,20 @@ protected function printHeader()
     protected function getFormattedHeader()
     {
         $standard = $this->ruleset->name;
-        $output   = '<html>'.PHP_EOL;
-        $output  .= ' <head>'.PHP_EOL;
-        $output  .= "  <title>$standard Coding Standards</title>".PHP_EOL;
-        $output  .= '  '.str_replace("\n", PHP_EOL, self::STYLESHEET).PHP_EOL;
-        $output  .= ' </head>'.PHP_EOL;
-        $output  .= ' <body>'.PHP_EOL;
-        $output  .= "  <h1>$standard Coding Standards</h1>".PHP_EOL;
-
-        return $output;
+        $output   = sprintf(
+            '<html>
+ <head>
+  <title>%1$s Coding Standards</title>
+  %2$s
+ </head>
+ <body>
+  <h1>%1$s Coding Standards</h1>',
+            $standard,
+            self::STYLESHEET
+        );
+
+        // Use the correct line endings based on the OS.
+        return str_replace("\n", PHP_EOL, $output).PHP_EOL;
 
     }//end getFormattedHeader()
 
