Squiz/ArrayDeclaration: improves test coverage

This commit adds tests that were previously missing. There are still
some uncovered lines in this sniff, those lines might be unreachable,
but I did not investigate this at this time. There is also potentially
some more relevant tests that could be added for lines that are already
covered. This is also not addressed in this commit.

Author: rodrigoprimo

src/Standards/Squiz/Tests/Arrays/ArrayDeclarationUnitTest.1.inc

@@ -19,7 +19,7 @@ class TestClass
                     'height' => '',
                    );
 
-    private $_bad = Array(
+    private $_bad = ARRAY(
                     'width' => '',
                     'height' => ''
                      );
@@ -547,3 +547,14 @@ $x = array(
       1, static::helloWorld(), $class instanceof static,
       2,
      );
+
+$noSpaceBeforeDoubleArrow = array(
+                             'width'=> '',
+                             'height' => '',
+                            );
+
+$newlineAfterDoubleArrow = array(
+                            'width'  =>
+                            '',
+                            'height' => '',
+                           );

src/Standards/Squiz/Tests/Arrays/ArrayDeclarationUnitTest.1.inc.fixed

@@ -586,3 +586,13 @@ $x = array(
       $class instanceof static,
       2,
      );
+
+$noSpaceBeforeDoubleArrow = array(
+                             'width'  => '',
+                             'height' => '',
+                            );
+
+$newlineAfterDoubleArrow = array(
+                            'width'  => '',
+                            'height' => '',
+                           );

src/Standards/Squiz/Tests/Arrays/ArrayDeclarationUnitTest.2.inc

@@ -536,3 +536,14 @@ $x = [
       1, static::helloWorld(), $class instanceof static,
       2,
      ];
+
+$noSpaceBeforeDoubleArrow = [
+                             'width'=> '',
+                             'height' => '',
+                            ];
+
+$newlineAfterDoubleArrow = [
+                            'width'  =>
+                            '',
+                            'height' => '',
+                           ];

src/Standards/Squiz/Tests/Arrays/ArrayDeclarationUnitTest.2.inc.fixed

@@ -573,3 +573,13 @@ $x = [
       $class instanceof static,
       2,
      ];
+
+$noSpaceBeforeDoubleArrow = [
+                             'width'  => '',
+                             'height' => '',
+                            ];
+
+$newlineAfterDoubleArrow = [
+                            'width'  => '',
+                            'height' => '',
+                           ];

src/Standards/Squiz/Tests/Arrays/ArrayDeclarationUnitTest.3.inc

@@ -0,0 +1,7 @@
+<?php
+
+// Intentional parse error (missing closing parenthesis).
+// This should be the only test in this file.
+// Testing that the sniff is *not* triggered.
+
+$array = array(

src/Standards/Squiz/Tests/Arrays/ArrayDeclarationUnitTest.php

@@ -136,6 +136,8 @@ public function getErrorList($testFile='')
                 537 => 1,
                 540 => 1,
                 547 => 2,
+                552 => 1,
+                557 => 1,
             ];
         case 'ArrayDeclarationUnitTest.2.inc':
             return [
@@ -229,6 +231,8 @@ public function getErrorList($testFile='')
                 526 => 1,
                 529 => 1,
                 536 => 2,
+                541 => 1,
+                546 => 1,
             ];
         default:
             return [];