Merge pull request #163 from rodrigoprimo/update-assignement-in-condition-code-coverage

Generic/AssignmentInCondition: improve sniff code coverage

Author: jrfnl

src/Standards/Generic/Tests/CodeAnalysis/AssignmentInConditionUnitTest.inc renamed to src/Standards/Generic/Tests/CodeAnalysis/AssignmentInConditionUnitTest.1.inc

@@ -0,0 +1,4 @@
+<?php
+
+// Intentional parse error. Testing that the sniff is *not* triggered in this case.
+if ($a == 123

src/Standards/Generic/Tests/CodeAnalysis/AssignmentInConditionUnitTest.2.inc

@@ -0,0 +1,4 @@
+<?php
+
+// Intentional parse error. Testing that the sniff is *not* triggered in this case.
+for ($i = 0; $i == 100; $i++

src/Standards/Generic/Tests/CodeAnalysis/AssignmentInConditionUnitTest.3.inc

@@ -0,0 +1,6 @@
+<?php
+
+// Intentional parse error. Testing that the sniff is *not* triggered in this case.
+for ($i = 0) {
+    echo 'foo';
+}

src/Standards/Generic/Tests/CodeAnalysis/AssignmentInConditionUnitTest.4.inc

@@ -0,0 +1,6 @@
+<?php
+
+// Intentional parse error. Testing that the sniff is *not* triggered in this case.
+for ($i = 0; $i == 100) {
+    echo 'foo';
+}

src/Standards/Generic/Tests/CodeAnalysis/AssignmentInConditionUnitTest.5.inc

@@ -0,0 +1,5 @@
+<?php
+
+// Intentional parse error. Testing that the sniff is *not* triggered in this case.
+switch ( true ) {
+    case $sample == 'something'

src/Standards/Generic/Tests/CodeAnalysis/AssignmentInConditionUnitTest.6.inc

@@ -41,46 +41,54 @@ public function getErrorList()
      * The key of the array should represent the line number and the value
      * should represent the number of warnings that should occur on that line.
      *
+     * @param string $testFile The name of the file being tested.
+     *
      * @return array<int, int>
      */
-    public function getWarningList()
+    public function getWarningList($testFile='')
     {
-        return [
-            46 => 1,
-            47 => 1,
-            48 => 1,
-            49 => 1,
-            50 => 1,
-            51 => 1,
-            52 => 1,
-            53 => 1,
-            54 => 1,
-            55 => 1,
-            56 => 1,
-            57 => 1,
-            58 => 1,
-            59 => 1,
-            60 => 1,
-            61 => 2,
-            63 => 1,
-            64 => 1,
-            67 => 1,
-            68 => 1,
-            69 => 1,
-            70 => 1,
-            71 => 1,
-            72 => 1,
-            73 => 1,
-            75 => 1,
-            77 => 1,
-            80 => 2,
-            84 => 1,
-            85 => 2,
-            88 => 1,
-            90 => 1,
-            92 => 1,
-            95 => 1,
-        ];
+        switch ($testFile) {
+        case 'AssignmentInConditionUnitTest.1.inc':
+            return [
+                46 => 1,
+                47 => 1,
+                48 => 1,
+                49 => 1,
+                50 => 1,
+                51 => 1,
+                52 => 1,
+                53 => 1,
+                54 => 1,
+                55 => 1,
+                56 => 1,
+                57 => 1,
+                58 => 1,
+                59 => 1,
+                60 => 1,
+                61 => 2,
+                63 => 1,
+                64 => 1,
+                67 => 1,
+                68 => 1,
+                69 => 1,
+                70 => 1,
+                71 => 1,
+                72 => 1,
+                73 => 1,
+                75 => 1,
+                77 => 1,
+                80 => 2,
+                84 => 1,
+                85 => 2,
+                88 => 1,
+                90 => 1,
+                92 => 1,
+                95 => 1,
+            ];
+
+        default:
+            return [];
+        }//end switch
 
     }//end getWarningList()