Various sniffs: simplify skipping the rest of the file

This commit updates various sniffs to use `return $phpcsFile->numTokens` instead of `return ($phpcsFile->numTokens + 1)`.

If a sniff file contains 50 tokens, the last `$stackPtr` will be 49, so returning `50` will already get us passed the end of the token stack and the `+ 1` is redundant.

Author: jrfnl

src/Standards/Generic/Sniffs/ControlStructures/InlineControlStructureSniff.php

@@ -125,7 +125,7 @@ public function process(File $phpcsFile, $stackPtr)
             // tag in short open tags and scan run with short_open_tag=Off.
             // Bow out completely as any further detection will be unreliable
             // and create incorrect fixes or cause fixer conflicts.
-            return ($phpcsFile->numTokens + 1);
+            return $phpcsFile->numTokens;
         }
 
         unset($nextNonEmpty, $start);

src/Standards/Generic/Sniffs/Files/EndFileNewlineSniff.php

@@ -65,7 +65,7 @@ public function process(File $phpcsFile, $stackPtr)
         }
 
         // Ignore the rest of the file.
-        return ($phpcsFile->numTokens + 1);
+        return $phpcsFile->numTokens;
 
     }//end process()
 

src/Standards/Generic/Sniffs/Files/EndFileNoNewlineSniff.php

@@ -72,7 +72,7 @@ public function process(File $phpcsFile, $stackPtr)
         }
 
         // Ignore the rest of the file.
-        return ($phpcsFile->numTokens + 1);
+        return $phpcsFile->numTokens;
 
     }//end process()
 

src/Standards/Generic/Sniffs/Files/ExecutableFileSniff.php

@@ -54,7 +54,7 @@ public function process(File $phpcsFile, $stackPtr)
         }
 
         // Ignore the rest of the file.
-        return ($phpcsFile->numTokens + 1);
+        return $phpcsFile->numTokens;
 
     }//end process()
 

src/Standards/Generic/Sniffs/Files/LineEndingsSniff.php

@@ -57,7 +57,7 @@ public function process(File $phpcsFile, $stackPtr)
 
         if ($found === $this->eolChar) {
             // Ignore the rest of the file.
-            return ($phpcsFile->numTokens + 1);
+            return $phpcsFile->numTokens;
         }
 
         // Check for single line files without an EOL. This is a very special
@@ -68,7 +68,7 @@ public function process(File $phpcsFile, $stackPtr)
             if ($tokens[$lastToken]['line'] === 1
                 && $tokens[$lastToken]['content'] !== "\n"
             ) {
-                return ($phpcsFile->numTokens + 1);
+                return $phpcsFile->numTokens;
             }
         }
 
@@ -124,7 +124,7 @@ public function process(File $phpcsFile, $stackPtr)
         }//end if
 
         // Ignore the rest of the file.
-        return ($phpcsFile->numTokens + 1);
+        return $phpcsFile->numTokens;
 
     }//end process()
 

src/Standards/Generic/Sniffs/Files/LineLengthSniff.php

@@ -80,7 +80,7 @@ public function process(File $phpcsFile, $stackPtr)
         $this->checkLineLength($phpcsFile, $tokens, $i);
 
         // Ignore the rest of the file.
-        return ($phpcsFile->numTokens + 1);
+        return $phpcsFile->numTokens;
 
     }//end process()
 

src/Standards/Generic/Sniffs/Files/LowercasedFilenameSniff.php

@@ -44,7 +44,7 @@ public function process(File $phpcsFile, $stackPtr)
     {
         $filename = $phpcsFile->getFilename();
         if ($filename === 'STDIN') {
-            return  ($phpcsFile->numTokens + 1);
+            return $phpcsFile->numTokens;
         }
 
         $filename          = basename($filename);
@@ -62,7 +62,7 @@ public function process(File $phpcsFile, $stackPtr)
         }
 
         // Ignore the rest of the file.
-        return ($phpcsFile->numTokens + 1);
+        return $phpcsFile->numTokens;
 
     }//end process()
 

src/Standards/Generic/Sniffs/PHP/SyntaxSniff.php

@@ -67,7 +67,7 @@ public function process(File $phpcsFile, $stackPtr)
         }
 
         // Ignore the rest of the file.
-        return ($phpcsFile->numTokens + 1);
+        return $phpcsFile->numTokens;
 
     }//end process()
 

src/Standards/Generic/Sniffs/VersionControl/GitMergeConflictSniff.php

@@ -123,7 +123,7 @@ public function process(File $phpcsFile, $stackPtr)
         }//end for
 
         // Ignore the rest of the file.
-        return ($phpcsFile->numTokens + 1);
+        return $phpcsFile->numTokens;
 
     }//end process()
 

src/Standards/Generic/Sniffs/VersionControl/SubversionPropertiesSniff.php

@@ -58,7 +58,7 @@ public function process(File $phpcsFile, $stackPtr)
         $properties = $this->getProperties($path);
         if ($properties === null) {
             // Not under version control.
-            return ($phpcsFile->numTokens + 1);
+            return $phpcsFile->numTokens;
         }
 
         $allProperties = ($properties + $this->properties);
@@ -101,7 +101,7 @@ public function process(File $phpcsFile, $stackPtr)
         }//end foreach
 
         // Ignore the rest of the file.
-        return ($phpcsFile->numTokens + 1);
+        return $phpcsFile->numTokens;
 
     }//end process()