Squiz/IncrementDecrementUsage: bug fix - code without whitespace [1]

As this is a sniff looking for certain functional code patterns, the sniff should disregard whitespace and comments when looking for the relevant tokens to determine whether the code under scan contains the code pattern the sniff is looking for.

The sniff, however, does not do this correctly (in multiple places).

This commit fixes just one of these issues, as reported in 325.

For this particular issue, the `$startPtr` for the `findNext()` is incremented for each `while` loop, but the initial `$startPtr` was also incremented, which meant that if there was no whitespace after an equals sign, the first relevant token was being skipped over.

Fixed now.

Includes tests.

Fixes 325

Author: jrfnl

src/Standards/Squiz/Sniffs/Operators/IncrementDecrementUsageSniff.php

@@ -165,8 +165,8 @@ protected function processAssignment($phpcsFile, $stackPtr)
 
         // We have only one variable, and it's the same as what is being assigned,
         // so we need to check what is being added or subtracted.
-        $nextNumber     = ($stackPtr + 1);
-        $previousNumber = ($stackPtr + 1);
+        $nextNumber     = $stackPtr;
+        $previousNumber = $stackPtr;
         $numberCount    = 0;
         while (($nextNumber = $phpcsFile->findNext([T_LNUMBER], ($nextNumber + 1), $statementEnd, false)) !== false) {
             $previousNumber = $nextNumber;

src/Standards/Squiz/Tests/Operators/IncrementDecrementUsageUnitTest.inc

@@ -40,3 +40,6 @@ $expected[($i + 1)]['sort_order'] = ($i + 1);
 $id = $id.($obj->i++).$id;
 $id = $obj?->i++.$id;
 $id = $obj?->i++*10;
+
+$var+=1;
+$var-=1;

src/Standards/Squiz/Tests/Operators/IncrementDecrementUsageUnitTest.php

@@ -42,6 +42,8 @@ public function getErrorList()
             31 => 1,
             41 => 1,
             42 => 1,
+            44 => 1,
+            45 => 1,
         ];
 
     }//end getErrorList()