Skip to content

Commit 99f4260

Browse files
rodrigoprimojrfnl
authored andcommitted
Add links to all issues in the 3.4.2, 3.4.1 and 3.4.0 sections of the changelog
This commit also fixes a few typos in the three changelogs.
1 parent 1e8cf1d commit 99f4260

File tree

1 file changed

+73
-38
lines changed

1 file changed

+73
-38
lines changed

CHANGELOG.md

Lines changed: 73 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -1551,16 +1551,26 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
15511551
### Fixed
15521552
- Fixed an issue where the PCRE JIT on PHP 7.3 caused PHPCS to die when using the parallel option
15531553
- PHPCS now disables the PCRE JIT before running
1554-
- Fixed bug #2368 : MySource.PHP.AjaxNullComparison throws error when first function has no doc comment
1555-
- Fixed bug #2414 : Indention false positive in switch/case/if combination
1556-
- Fixed bug #2423 : Squiz.Formatting.OperatorBracket.MissingBrackets error with static
1557-
- Fixed bug #2450 : Indentation false positive when closure containing nested IF conditions used as function argument
1558-
- Fixed bug #2452 : LowercasePHPFunctions sniff failing on "new \File()"
1559-
- Fixed bug #2453 : Squiz.CSS.SemicolonSpacingSniff false positive when style name proceeded by an asterisk
1560-
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1561-
- Fixed bug #2464 : Fixer conflict between Generic.WhiteSpace.ScopeIndent and Squiz.WhiteSpace.ScopeClosingBrace when class indented 1 space
1562-
- Fixed bug #2465 : Excluding a sniff by path is not working
1563-
- Fixed bug #2467 : PHP open/close tags inside CSS files are replaced with internal PHPCS token strings when auto fixing
1554+
- Fixed bug [#2368] : MySource.PHP.AjaxNullComparison throws error when first function has no doc comment
1555+
- Fixed bug [#2414] : Indention false positive in switch/case/if combination
1556+
- Fixed bug [#2423] : Squiz.Formatting.OperatorBracket.MissingBrackets error with static
1557+
- Fixed bug [#2450] : Indentation false positive when closure containing nested IF conditions used as function argument
1558+
- Fixed bug [#2452] : LowercasePHPFunctions sniff failing on "new \File()"
1559+
- Fixed bug [#2453] : Squiz.CSS.SemicolonSpacingSniff false positive when style name proceeded by an asterisk
1560+
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1561+
- Fixed bug [#2464] : Fixer conflict between Generic.WhiteSpace.ScopeIndent and Squiz.WhiteSpace.ScopeClosingBrace when class indented 1 space
1562+
- Fixed bug [#2465] : Excluding a sniff by path is not working
1563+
- Fixed bug [#2467] : PHP open/close tags inside CSS files are replaced with internal PHPCS token strings when auto fixing
1564+
1565+
[#2368]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2368
1566+
[#2414]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2414
1567+
[#2423]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2423
1568+
[#2450]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2450
1569+
[#2452]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2452
1570+
[#2453]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2453
1571+
[#2464]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2464
1572+
[#2465]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2465
1573+
[#2467]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2467
15641574

15651575
## [3.4.1] - 2019-03-19
15661576
### Changed
@@ -1588,16 +1598,16 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
15881598
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
15891599
- Generic.Files.LineEndings no longer adds superfluous new line at the end of JS and CSS files
15901600
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1591-
- Generic.Formatting.DisallowMultipleStatements no longer tries fix lines containing phpcs:ignore statements
1601+
- Generic.Formatting.DisallowMultipleStatements no longer tries to fix lines containing phpcs:ignore statements
15921602
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
15931603
- Generic.Functions.FunctionCallArgumentSpacing now has improved performance and anonymous class support
15941604
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
15951605
- Generic.WhiteSpace.ScopeIndent now respects changes to the "exact" property using phpcs:set mid-way through a file
1596-
- This allows you change the "exact" rule for only some parts of a file
1606+
- This allows you to change the "exact" rule for only some parts of a file
15971607
- Generic.WhiteSpace.ScopeIndent now disables exact indent checking inside all arrays
15981608
- Previously, this was only done when using long array syntax, but it now works for short array syntax as well
15991609
- PEAR.Classes.ClassDeclaration now has improved handling of PHPCS annotations and tab indents
1600-
- PSR12.Classes.ClassInstantiation has changed it's error code from MissingParenthesis to MissingParentheses
1610+
- PSR12.Classes.ClassInstantiation has changed its error code from MissingParenthesis to MissingParentheses
16011611
- PSR12.Keywords.ShortFormTypeKeywords now ignores all spacing inside type casts during both checking and fixing
16021612
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
16031613
- Squiz.Classes.LowercaseClassKeywords now examines the class keyword for anonymous classes
@@ -1637,16 +1647,24 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
16371647
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
16381648

16391649
### Fixed
1640-
- Fixed bug #2298 : PSR2.Classes.ClassDeclaration allows extended class on new line
1650+
- Fixed bug [#2298] : PSR2.Classes.ClassDeclaration allows extended class on new line
16411651
- Thanks to [Michał Bundyra][@michalbundyra] for the patch
1642-
- Fixed bug #2337 : Generic.WhiteSpace.ScopeIndent incorrect error when multi-line function call starts on same line as open tag
1643-
- Fixed bug #2348 : Cache not invalidated when changing a ruleset included by another
1644-
- Fixed bug #2376 : Using __halt_compiler() breaks Generic.PHP.ForbiddenFunctions unless it's last in the function list
1652+
- Fixed bug [#2337] : Generic.WhiteSpace.ScopeIndent incorrect error when multi-line function call starts on same line as open tag
1653+
- Fixed bug [#2348] : Cache not invalidated when changing a ruleset included by another
1654+
- Fixed bug [#2376] : Using __halt_compiler() breaks Generic.PHP.ForbiddenFunctions unless it's last in the function list
16451655
- Thanks to [Sijun Zhu][@Billz95] for the patch
1646-
- Fixed bug #2393 : The gitmodified filter will infinitely loop when encountering deleted file paths
1656+
- Fixed bug [#2393] : The gitmodified filter will infinitely loop when encountering deleted file paths
16471657
- Thanks to [Lucas Manzke][@lmanzke] for the patch
1648-
- Fixed bug #2396 : Generic.WhiteSpace.ScopeIndent incorrect error when multi-line IF condition mixed with HTML
1649-
- Fixed bug #2431 : Use function/const not tokenized as T_STRING when preceded by comment
1658+
- Fixed bug [#2396] : Generic.WhiteSpace.ScopeIndent incorrect error when multi-line IF condition mixed with HTML
1659+
- Fixed bug [#2431] : Use function/const not tokenized as T_STRING when preceded by comment
1660+
1661+
[#2298]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2298
1662+
[#2337]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2337
1663+
[#2348]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2348
1664+
[#2376]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2376
1665+
[#2393]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2393
1666+
[#2396]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2396
1667+
[#2431]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2431
16501668

16511669
## [3.4.0] - 2018-12-20
16521670
### Deprecated
@@ -1671,7 +1689,7 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
16711689
- This change also converts '(binary)' from T_STRING_CAST to T_BINARY_CAST
16721690
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the help with this patch
16731691
- Array properties set inside a ruleset.xml file can now extend a previous value instead of always overwriting it
1674-
- e.g., if you include a ruleset that defines forbidden functions, can you now add to that list instead of having to redefine it
1692+
- e.g., if you include a ruleset that defines forbidden functions, can you now add to that list instead of having to redefine it
16751693
- To use this feature, add extends="true" to the property tag
16761694
- e.g., property name="forbiddenFunctionNames" type="array" extend="true"
16771695
- Thanks to [Michael Moravec][@Majkl578] for the patch
@@ -1715,7 +1733,7 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
17151733
- Squiz.Scope.MethodScope
17161734
- Squiz.Scope.StaticThisUsage
17171735
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1718-
- Generic.CodeAnalysis.UnusedFunctionParameter now only skips functions with empty bodies when the class implements an interface
1736+
- Generic.CodeAnalysis.UnusedFunctionParameter now only skips functions with empty bodies when the class implements an interface
17191737
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
17201738
- Generic.CodeAnalysis.UnusedFunctionParameter now has additional error codes to indicate where unused params were found
17211739
- The new error code prefixes are:
@@ -1788,36 +1806,53 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
17881806
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
17891807

17901808
### Fixed
1791-
- Fixed bug #2109 : Generic.Functions.CallTimePassByReference false positive for bitwise and used in function argument
1792-
- Fixed bug #2165 : Conflict between Squiz.Arrays.ArrayDeclaration and ScopeIndent sniffs when heredoc used in array
1793-
- Fixed bug #2167 : Generic.WhiteSpace.ScopeIndent shows invalid error when scope opener indented inside inline HTML
1794-
- Fixed bug #2178 : Generic.NamingConventions.ConstructorName matches methods in anon classes with same name as containing class
1809+
- Fixed bug [#2109] : Generic.Functions.CallTimePassByReference false positive for bitwise and used in function argument
1810+
- Fixed bug [#2165] : Conflict between Squiz.Arrays.ArrayDeclaration and ScopeIndent sniffs when heredoc used in array
1811+
- Fixed bug [#2167] : Generic.WhiteSpace.ScopeIndent shows invalid error when scope opener indented inside inline HTML
1812+
- Fixed bug [#2178] : Generic.NamingConventions.ConstructorName matches methods in anon classes with same name as containing class
17951813
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1796-
- Fixed bug #2190 : PEAR.Functions.FunctionCallSignature incorrect error when encountering trailing PHPCS annotation
1814+
- Fixed bug [#2190] : PEAR.Functions.FunctionCallSignature incorrect error when encountering trailing PHPCS annotation
17971815
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1798-
- Fixed bug #2194 : Generic.Whitespace.LanguageConstructSpacing should not be checking namespace operators
1816+
- Fixed bug [#2194] : Generic.Whitespace.LanguageConstructSpacing should not be checking namespace operators
17991817
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1800-
- Fixed bug #2202 : Squiz.WhiteSpace.OperatorSpacing throws error for negative index when using curly braces for string access
1818+
- Fixed bug [#2202] : Squiz.WhiteSpace.OperatorSpacing throws error for negative index when using curly braces for string access
18011819
- Same issue fixed in Squiz.Formatting.OperatorBracket
18021820
- Thanks to [Andreas Buchenrieder][@anbuc] for the patch
1803-
- Fixed bug #2210 : Generic.NamingConventions.CamelCapsFunctionName not ignoring SoapClient __getCookies() method
1821+
- Fixed bug [#2210] : Generic.NamingConventions.CamelCapsFunctionName not ignoring SoapClient __getCookies() method
18041822
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1805-
- Fixed bug #2211 : PSR2.Methods.MethodDeclaration gets confused over comments between modifier keywords
1823+
- Fixed bug [#2211] : PSR2.Methods.MethodDeclaration gets confused over comments between modifier keywords
18061824
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1807-
- Fixed bug #2212 : FUNCTION and CONST in use groups being tokenised as T_FUNCTION and T_CONST
1825+
- Fixed bug [#2212] : FUNCTION and CONST in use groups being tokenized as T_FUNCTION and T_CONST
18081826
- Thanks to [Chris Wilkinson][@thewilkybarkid] for the patch
1809-
- Fixed bug #2214 : File::getMemberProperties() is recognizing method params as properties
1827+
- Fixed bug [#2214] : File::getMemberProperties() is recognizing method params as properties
18101828
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1811-
- Fixed bug #2236 : Memory info measurement unit is Mb but probably should be MB
1812-
- Fixed bug #2246 : CSS tokenizer does not tokenize class names correctly when they contain the string NEW
1829+
- Fixed bug [#2236] : Memory info measurement unit is Mb but probably should be MB
1830+
- Fixed bug [#2246] : CSS tokenizer does not tokenize class names correctly when they contain the string NEW
18131831
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1814-
- Fixed bug #2278 : Squiz.Operators.ComparisonOperatorUsage false positive when inline IF contained in parentheses
1832+
- Fixed bug [#2278] : Squiz.Operators.ComparisonOperatorUsage false positive when inline IF contained in parentheses
18151833
- Thanks to [Arnout Boks][@aboks] for the patch
1816-
- Fixed bug #2284 : Squiz.Functions.FunctionDeclarationArgumentSpacing removing type hint during fixing
1834+
- Fixed bug [#2284] : Squiz.Functions.FunctionDeclarationArgumentSpacing removing type hint during fixing
18171835
- Thanks to [Michał Bundyra][@michalbundyra] for the patch
1818-
- Fixed bug #2297 : Anonymous class not tokenized correctly when used as argument to another anon class
1836+
- Fixed bug [#2297] : Anonymous class not tokenized correctly when used as argument to another anon class
18191837
- Thanks to [Michał Bundyra][@michalbundyra] for the patch
18201838

1839+
[#2109]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2109
1840+
[#2165]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2165
1841+
[#2167]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2167
1842+
[#2178]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2178
1843+
[#2190]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2190
1844+
[#2194]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2194
1845+
[#2202]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2202
1846+
[#2210]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2210
1847+
[#2211]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2211
1848+
[#2212]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2212
1849+
[#2214]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2214
1850+
[#2236]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2236
1851+
[#2246]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2246
1852+
[#2278]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2278
1853+
[#2284]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2284
1854+
[#2297]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2297
1855+
18211856
## [2.9.2] - 2018-11-08
18221857
### Changed
18231858
- PHPCS should now run under PHP 7.3 without deprecation warnings

0 commit comments

Comments
 (0)