Tests/Tokenizer: tests for T_CASE and T_IF scope condition

This commit moves a sniff test to tokenizer tests. Originally, the test
was added in fddc61a which is part of
squizlabs/PHP_CodeSniffer#497. fddc61a
introduced a test to a sniff test
(InlineControlStructureUnitTest.php) as back then there were no
Tokenizer tests. Those tests were added to ensure that
Tokenizer::recurseScopeMap() would correctly add scope information to
the `T_CASE` token when it shares the closer with `T_SWITCH` and to
`T_IF` when a nested `T_CASE` shares the scope closer with `T_SWITCH`.

Now that the InlineControlStructure sniff doesn't listen for the
T_SWITCH token anymore, the original test added in fddc61a became
useless and thus was refactored to use different control structure.

Author: rodrigoprimo

src/Standards/Generic/Tests/ControlStructures/InlineControlStructureUnitTest.1.inc

@@ -88,17 +88,17 @@ if ($error === ERROR_INVALID_GENDER): ?>
 
 
 
-if ($this->allowShopping !== true):
-    if ($this->status != Shop_Cart :: OK):
-        switch ($this->status):
-            case Shop_Cart :: NOT_FOUND:
-            echo 'foo';
-        endswitch;
+if ($value):
+    if ($anotherValue):
+        foreach ($array as $element):
+            echo $element;
+        endforeach;
     endif;
 else:
     echo 'foo';
 endif;
 
+
 // ELSE IF split over multiple lines (not inline)
 if ($test) {
 } else

src/Standards/Generic/Tests/ControlStructures/InlineControlStructureUnitTest.1.inc.fixed

@@ -100,17 +100,17 @@ if ($error === ERROR_INVALID_GENDER): ?>
 
 
 
-if ($this->allowShopping !== true):
-    if ($this->status != Shop_Cart :: OK):
-        switch ($this->status):
-            case Shop_Cart :: NOT_FOUND:
-            echo 'foo';
-        endswitch;
+if ($value):
+    if ($anotherValue):
+        foreach ($array as $element):
+            echo $element;
+        endforeach;
     endif;
 else:
     echo 'foo';
 endif;
 
+
 // ELSE IF split over multiple lines (not inline)
 if ($test) {
 } else

tests/Core/Tokenizer/Tokenizer/RecurseScopeMapCaseKeywordConditionsTest.inc

@@ -93,3 +93,10 @@ enum Foo: string {
     /* testKeywordAsEnumCaseNameShouldBeString7 */
     case ARRAY = 'array';
 }
+
+// Test for https://github.com/squizlabs/PHP_CodeSniffer/issues/497
+switch ($value):
+    /* testSwitchCaseWithoutBreakReturn */
+    case 1:
+        echo 'one';
+endswitch;

tests/Core/Tokenizer/Tokenizer/RecurseScopeMapCaseKeywordConditionsTest.php

@@ -106,6 +106,7 @@ public static function dataNotEnumCases()
             'switch case with constant, keyword in mixed case'   => ['/* testIsNotEnumCaseIsCaseInsensitive */'],
             'switch case, body in curlies declares enum'         => ['/* testCaseInSwitchWhenCreatingEnumInSwitch1 */'],
             'switch case, body after semicolon declares enum'    => ['/* testCaseInSwitchWhenCreatingEnumInSwitch2 */'],
+            'switch case, shared closer with switch'             => ['/* testSwitchCaseWithoutBreakReturn */'],
         ];
 
     }//end dataNotEnumCases()

tests/Core/Tokenizer/Tokenizer/RecurseScopeMapIfKeywordConditionsTest.inc

@@ -0,0 +1,13 @@
+<?php
+
+// Test for https://github.com/squizlabs/PHP_CodeSniffer/issues/497
+/* testIfElseWithNestedCaseMissingBreak */
+if ($foo === true):
+    switch ($bar):
+        case 1:
+            echo 'one';
+    endswitch;
+/* testIfElseWithNestedCaseMissingBreakCloser */
+else:
+    echo 'other';
+endif;

tests/Core/Tokenizer/Tokenizer/RecurseScopeMapIfKeywordConditionsTest.php

@@ -0,0 +1,76 @@
+<?php
+/**
+ * Tests setting the scope for T_IF token.
+ *
+ * @author    Juliette Reinders Folmer <[email protected]>
+ * @author    Rodrigo Primo <[email protected]>
+ * @copyright 2021 Squiz Pty Ltd (ABN 77 084 670 600)
+ * @license   https://github.com/PHPCSStandards/PHP_CodeSniffer/blob/master/licence.txt BSD Licence
+ */
+
+namespace PHP_CodeSniffer\Tests\Core\Tokenizer\Tokenizer;
+
+use PHP_CodeSniffer\Tests\Core\Tokenizer\AbstractTokenizerTestCase;
+
+final class RecurseScopeMapIfKeywordConditionsTest extends AbstractTokenizerTestCase
+{
+
+
+    /**
+     * Tests setting the scope for T_IF token with nested case statement missing break statement.
+     *
+     * @link https://github.com/squizlabs/PHP_CodeSniffer/issues/497#ref-commit-fddc61a
+     *
+     * @covers \PHP_CodeSniffer\Tokenizers\Tokenizer::recurseScopeMap
+     *
+     * @return void
+     */
+    public function testIfElseWithNestedCaseMissingBreakSharedClosers()
+    {
+
+        $tokens       = $this->phpcsFile->getTokens();
+        $ifTestMarker = '/* testIfElseWithNestedCaseMissingBreak */';
+        $ifCloserTestMarker = '/* testIfElseWithNestedCaseMissingBreakCloser */';
+        $ifTokenIndex       = $this->getTargetToken($ifTestMarker, T_IF);
+        $tokenArray         = $tokens[$ifTokenIndex];
+
+        $expectedScopeCondition = $ifTokenIndex;
+        $expectedScopeOpener    = $this->getTargetToken($ifTestMarker, T_COLON);
+        $expectedScopeCloser    = $this->getTargetToken($ifCloserTestMarker, T_ELSE);
+
+        $this->assertArrayHasKey('scope_condition', $tokenArray, 'Scope condition not set');
+        $this->assertSame(
+            $expectedScopeCondition,
+            $tokenArray['scope_condition'],
+            sprintf(
+                'Scope condition not set correctly; expected T_IF, found %s',
+                $tokens[$tokenArray['scope_condition']]['type']
+            )
+        );
+
+        $this->assertArrayHasKey('scope_opener', $tokenArray, 'Scope opener not set');
+        $this->assertSame(
+            $expectedScopeOpener,
+            $tokenArray['scope_opener'],
+            sprintf(
+                'Scope opener not set correctly; expected %s, found %s',
+                $tokens[$expectedScopeOpener]['type'],
+                $tokens[$tokenArray['scope_opener']]['type']
+            )
+        );
+
+        $this->assertArrayHasKey('scope_closer', $tokenArray, 'Scope closer not set');
+        $this->assertSame(
+            $expectedScopeCloser,
+            $tokenArray['scope_closer'],
+            sprintf(
+                'Scope closer not set correctly; expected %s, found %s',
+                $tokens[$expectedScopeCloser]['type'],
+                $tokens[$tokenArray['scope_closer']]['type']
+            )
+        );
+
+    }//end testIfElseWithNestedCaseMissingBreakSharedClosers()
+
+
+}//end class