Skip to content

Commit a9a1c4c

Browse files
committed
Generic/GitMergeConflict: check files using only short open echo tag
Includes unit tests.
1 parent ae4f33b commit a9a1c4c

File tree

5 files changed

+35
-1
lines changed

5 files changed

+35
-1
lines changed

package.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -724,6 +724,7 @@ http://pear.php.net/dtd/package-2.0.xsd">
724724
<file baseinstalldir="PHP/CodeSniffer" name="GitMergeConflictUnitTest.4.inc" role="test" />
725725
<file baseinstalldir="PHP/CodeSniffer" name="GitMergeConflictUnitTest.5.inc" role="test" />
726726
<file baseinstalldir="PHP/CodeSniffer" name="GitMergeConflictUnitTest.6.inc" role="test" />
727+
<file baseinstalldir="PHP/CodeSniffer" name="GitMergeConflictUnitTest.7.inc" role="test" />
727728
<file baseinstalldir="PHP/CodeSniffer" name="GitMergeConflictUnitTest.js" role="test" />
728729
<file baseinstalldir="PHP/CodeSniffer" name="GitMergeConflictUnitTest.php" role="test" />
729730
<file baseinstalldir="PHP/CodeSniffer" name="SubversionPropertiesUnitTest.inc" role="test" />

src/Standards/Generic/Sniffs/VersionControl/GitMergeConflictSniff.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,10 @@ class GitMergeConflictSniff implements Sniff
3434
*/
3535
public function register()
3636
{
37-
return [T_OPEN_TAG];
37+
return [
38+
T_OPEN_TAG,
39+
T_OPEN_TAG_WITH_ECHO,
40+
];
3841

3942
}//end register()
4043

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
<!-- Test detecting merge conflicts in inline HTML. -->
2+
<div class="abc">
3+
<<<<<<< HEAD
4+
<p id="test-this">Testing a merge conflict.</p>
5+
=======
6+
<p id="test-that">Another text string.</p>
7+
>>>>>>> ref/heads/feature-branch
8+
</div>
9+
10+
<!-- Test detecting merge conflicts in inline HTML. -->
11+
<div class="abc">
12+
<<<<<<< HEAD
13+
<p id="test-this"><?= 'Testing a merge conflict.'; ?></p>
14+
=======
15+
<p id="test-that"><?= 'Another text string.'; ?></p>
16+
>>>>>>> ref/heads/feature-branch
17+
</div>
18+
19+
<?= $text; ?>

src/Standards/Generic/Tests/VersionControl/GitMergeConflictUnitTest.php

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,16 @@ public function getErrorList($testFile='GitMergeConflictUnitTest.1.inc')
9999
32 => 1,
100100
];
101101

102+
case 'GitMergeConflictUnitTest.7.inc':
103+
return [
104+
3 => 1,
105+
5 => 1,
106+
7 => 1,
107+
12 => 1,
108+
14 => 1,
109+
16 => 1,
110+
];
111+
102112
case 'GitMergeConflictUnitTest.1.css':
103113
return [
104114
3 => 1,

src/Standards/Squiz/Sniffs/WhiteSpace/SuperfluousWhitespaceSniff.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ public function register()
4949
{
5050
return [
5151
T_OPEN_TAG,
52+
T_OPEN_TAG_WITH_ECHO,
5253
T_CLOSE_TAG,
5354
T_WHITESPACE,
5455
T_COMMENT,

0 commit comments

Comments
 (0)