Skip to content

Commit b246455

Browse files
committed
Merge branch '3.x' into 4.x
2 parents fc86632 + e4b516b commit b246455

File tree

4 files changed

+17
-20
lines changed

4 files changed

+17
-20
lines changed

.github/workflows/build-phar.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545
strategy:
4646
matrix:
4747
# Deliberately missing PHP 8.0 as that PHAR is build and used in the test workflow.
48-
php: ['7.2', '7.3', '7.4', '8.1', '8.2', '8.3', '8.4', 'nightly']
48+
php: ['7.2', '7.3', '7.4', '8.1', '8.2', '8.3', '8.4', '8.5', 'nightly']
4949

5050
name: "Build Phar on PHP: ${{ matrix.php }}"
5151

.github/workflows/end-to-end-tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,12 @@ jobs:
2727

2828
strategy:
2929
matrix:
30-
php: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5']
30+
php: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5', 'nightly']
3131

3232
# yamllint disable-line rule:line-length
3333
name: "E2E PHP: ${{ matrix.php }}"
3434

35-
continue-on-error: ${{ matrix.php == '8.5' }}
35+
continue-on-error: ${{ matrix.php == 'nightly' }}
3636

3737
steps:
3838
- name: Prepare git to leave line endings alone

.github/workflows/test.yml

Lines changed: 13 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -54,14 +54,14 @@ jobs:
5454
# code conditions.
5555
matrix:
5656
os: ['ubuntu-latest', 'windows-latest']
57-
php: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5']
57+
php: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5', '8.6']
5858
custom_ini: [false]
5959

6060
include:
6161
# Skip test runs on builds which are also run in the coverage job.
6262
- php: '7.2'
6363
skip_tests: true
64-
- php: '8.4'
64+
- php: '8.5'
6565
skip_tests: true
6666

6767
# Run a couple of builds with custom extensions to allow for testing ini handling within PHPCS.
@@ -88,20 +88,17 @@ jobs:
8888
- php: '7.4'
8989
os: 'ubuntu-latest'
9090
custom_ini: true
91-
- php: '8.3'
92-
os: 'ubuntu-latest'
93-
custom_ini: true
94-
- php: '8.0'
91+
- php: '8.1'
9592
os: 'ubuntu-latest'
9693
custom_ini: true
97-
- php: '8.2'
94+
- php: '8.3'
9895
os: 'ubuntu-latest'
9996
custom_ini: true
10097

10198
# yamllint disable-line rule:line-length
10299
name: "PHP: ${{ matrix.php }} ${{ matrix.custom_ini && ' with custom ini settings' || '' }}${{ matrix.libxml_minor && format( ' with libxml {0}', matrix.libxml_minor ) || '' }} (${{ matrix.os == 'ubuntu-latest' && 'Linux' || 'Win' }})"
103100

104-
continue-on-error: ${{ matrix.php == '8.5' }}
101+
continue-on-error: ${{ matrix.php == '8.6' }}
105102

106103
steps:
107104
- name: Prepare git to leave line endings alone
@@ -204,7 +201,7 @@ jobs:
204201
- name: Install Composer dependencies
205202
uses: "ramsey/composer-install@3cf229dc2919194e9e36783941438d17239e8520" # 3.1.1
206203
with:
207-
composer-options: ${{ matrix.php == '8.5' && '--ignore-platform-req=php+' || '' }}
204+
composer-options: ${{ matrix.php == '8.6' && '--ignore-platform-req=php+' || '' }}
208205
custom-cache-suffix: $(date -u "+%Y-%m")
209206

210207
- name: Grab PHPUnit version
@@ -236,14 +233,14 @@ jobs:
236233
run: php "vendor/bin/phpunit" -c ${{ steps.phpunit_config.outputs.FILE }} --no-coverage
237234

238235
# Do one test run against the complete test suite in CBF mode to ensure all tests can run in CBF mode.
239-
- name: 'PHPUnit: run the full test suite without code coverage in CBF mode (PHP 8.3 only)'
240-
if: ${{ matrix.php == '8.3' }}
236+
- name: 'PHPUnit: run the full test suite without code coverage in CBF mode (PHP 8.4 only)'
237+
if: ${{ matrix.php == '8.4' }}
241238
run: php "vendor/bin/phpunit" -c ${{ steps.phpunit_config.outputs.FILE }} --exclude-group nothing --no-coverage
242239
env:
243240
PHP_CODESNIFFER_CBF: '1'
244241

245242
- name: 'PHPUnit: run select tests in CBF mode'
246-
if: ${{ matrix.skip_tests != true && matrix.php != '8.3' }}
243+
if: ${{ matrix.skip_tests != true && matrix.php != '8.4' }}
247244
run: >
248245
php "vendor/bin/phpunit" -c ${{ steps.phpunit_config.outputs.FILE }} --no-coverage
249246
--group CBF --exclude-group nothing
@@ -275,22 +272,22 @@ jobs:
275272
strategy:
276273
matrix:
277274
os: ['ubuntu-latest', 'windows-latest']
278-
# Note: we can only run code coverage builds against PHP 7.2 and PHP 8.4 or higher:
275+
# Note: we can only run code coverage builds against PHP 7.2 and PHP 8.5 or higher:
279276
# - PHP 7.2 will work as it uses PHPUnit 8, which doesn't use PHP Parser yet.
280277
# - As of PHPUnit 9.3 (PHP 7.3+), PHPUnit started using PHP Parser for code coverage, and PHP Parser
281278
# also polyfills tokens, but to different (integer) values.
282279
# - Additionally, PHP Parser will block PHPUnit from running with a fatal error if it detects
283280
# non-integer values for polyfilled tokens.... _sigh_.
284281
# - So, aside from PHP 7.2, we can only run code coverage on the last PHP version (or higher)
285282
# which added a new token, which is polyfilled by both.
286-
# At the time of writing, this means PHP 8.4 or higher.
287-
php: ['7.2', '8.4']
283+
# At the time of writing, this means PHP 8.5 or higher.
284+
php: ['7.2', '8.5']
288285
custom_ini: [false]
289286

290287
include:
291288
# Also run one coverage build with custom ini settings for testing the DisallowShortOpenTag sniff.
292289
# Also run with a disabled extension for testing the handling of unsettable ini settings by PHPCS.
293-
- php: '8.4'
290+
- php: '8.5'
294291
os: 'ubuntu-latest'
295292
custom_ini: true
296293
extensions: ':mysqli' # Run with mysqli disabled.

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
[![License](https://img.shields.io/github/license/PHPCSStandards/PHP_CodeSniffer)](https://github.com/PHPCSStandards/PHP_CodeSniffer/blob/HEAD/licence.txt)
1010

1111
![Minimum PHP Version](https://img.shields.io/packagist/dependency-v/squizlabs/php_codesniffer/php.svg)
12-
[![Tested on PHP 7.2 to 8.4](https://img.shields.io/badge/tested%20on-PHP%207.2%20|%207.3%20|%207.4%20|%208.0%20|%208.1%20|%208.2%20|%208.3%20|%208.4-brightgreen.svg?maxAge=2419200)][GHA-test]
12+
[![Tested on PHP 7.2 to 8.5](https://img.shields.io/badge/tested%20on-PHP%207.2%20|%207.3%20|%207.4%20|%208.0%20|%208.1%20|%208.2%20|%208.3%20|%208.4%20|%208.5-brightgreen.svg?maxAge=2419200)][GHA-test]
1313

1414
[GHA-test]: https://github.com/PHPCSStandards/PHP_CodeSniffer/actions/workflows/test.yml
1515

0 commit comments

Comments
 (0)