Skip to content

Commit bc343a4

Browse files
committed
Merge branch 'master' into phpcs-fixer
2 parents efd8cd9 + 2845af7 commit bc343a4

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

CodeSniffer/Standards/Squiz/Sniffs/Functions/FunctionDeclarationArgumentSpacingSniff.php

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -191,12 +191,15 @@ public function processBracket(PHP_CodeSniffer_File $phpcsFile, $openBracket)
191191

192192
// Take references into account when expecting the
193193
// location of whitespace.
194-
if ($phpcsFile->isReference(($nextParam - 1)) === true
195-
|| $tokens[($nextParam - 1)]['code'] === T_ELLIPSIS
196-
) {
197-
$whitespace = ($nextParam - 2);
194+
$checkToken = ($nextParam - 1);
195+
if ($tokens[$checkToken]['code'] === T_ELLIPSIS) {
196+
$checkToken--;
197+
}
198+
199+
if ($phpcsFile->isReference($checkToken) === true) {
200+
$whitespace = ($checkToken - 1);
198201
} else {
199-
$whitespace = ($nextParam - 1);
202+
$whitespace = $checkToken;
200203
}
201204

202205
if (empty($params) === false) {

CodeSniffer/Standards/Squiz/Tests/Functions/FunctionDeclarationArgumentSpacingUnitTest.inc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,3 +60,4 @@ function myFunc( ) {}
6060
// @codingStandardsChangeSetting Squiz.Functions.FunctionDeclarationArgumentSpacing requiredSpacesBeforeClose 0
6161

6262
function myFunc($req, $opt=null, ...$params) {}
63+
function myFunc($param, &...$moreParams) {}

0 commit comments

Comments
 (0)